Skip to content

[Impeller] Fix fail to render pixel buffer texture on Linux #181656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaaclarke merged 7 commits into from
Feb 24, 2026
Merged

[Impeller] Fix fail to render pixel buffer texture on Linux #181656

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ca30228
Fix fail to render pixel buffer issue
xiaowei-guan Jan 26, 2026
999ef41
Add unit test
xiaowei-guan Feb 9, 2026
8da1bb3
Update unit test for rendering texture
xiaowei-guan Feb 10, 2026
9195a8d
Code format
xiaowei-guan Feb 10, 2026
55c900a
Add format check
xiaowei-guan Feb 11, 2026
d77c855
Trigger Build
xiaowei-guan Feb 12, 2026
2df7bd4
Trigger Build
xiaowei-guan Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update unit test for rendering texture 
1.Make the texture red on the top half and blue on the botton half.
2.Add a new image file.
  • Loading branch information
@xiaowei-guan
xiaowei-guan committed Feb 24, 2026
commit 8da1bb32339fa8d4278df801ebcc1cddd27f7092
1 change: 1 addition & 0 deletions engine/src/flutter/shell/platform/embedder/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ test_fixtures("fixtures") {
"fixtures/vk_dpr_noxform.png",
"fixtures/vk_gradient.png",
"fixtures/gradient_metal.png",
"fixtures/external_texture_impeller.png",
"fixtures/external_texture_metal.png",
"fixtures/gradient_xform.png",
"fixtures/scene_without_custom_compositor.png",
Expand Down
Binary file added engine/src/flutter/shell/platform/embedder/fixtures/external_texture_impeller.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 9 additions & 2 deletions engine/src/flutter/shell/platform/embedder/tests/embedder_gl_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4859,13 +4859,20 @@ TEST_F(EmbedderTest, RenderTextureWithImpellerOpenGL) {
[](void* user_data, int64_t texture_id, size_t width, size_t height,
FlutterOpenGLTexture* texture) -> bool {
std::vector<uint8_t> buffer(800 * 600 * 4);
for (int i = 0; i < 800 * 600; ++i) {
for (int i = 0; i < 800 * 300; ++i) {
buffer[i * 4 + 0] = 255; // Red channel
buffer[i * 4 + 1] = 0; // Green channel
buffer[i * 4 + 2] = 0; // Blue channel
buffer[i * 4 + 3] = 255; // Alpha channel (fully opaque)
}

for (int i = 800 * 300; i < 800 * 600; ++i) {
buffer[i * 4 + 0] = 0; // Red channel
buffer[i * 4 + 1] = 0; // Green channel
buffer[i * 4 + 2] = 255; // Blue channel
buffer[i * 4 + 3] = 255; // Alpha channel (fully opaque)
}

GLuint gl_texture;
glGenTextures(1, &gl_texture);
glBindTexture(GL_TEXTURE_2D, gl_texture);
Expand Down Expand Up @@ -4900,7 +4907,7 @@ TEST_F(EmbedderTest, RenderTextureWithImpellerOpenGL) {
kSuccess);
latch.Wait();
ASSERT_TRUE(
ImageMatchesFixture("external_texture_metal.png", rendered_scene));
ImageMatchesFixture("external_texture_impeller.png", rendered_scene));
}

TEST_F(EmbedderTest, ImpellerOpenGLImageSnapshot) {
Expand Down