Revert "ci: skip build phases on re-enqueue if artifacts already exist"#5974
Revert "ci: skip build phases on re-enqueue if artifacts already exist"#5974jyotshnayaparla-00 wants to merge 2 commits intomainfrom
Conversation
This reverts commit 60b70a9.
mythical-fred
left a comment
There was a problem hiding this comment.
The commit message and PR title say "Revert", but this isn't a clean revert. See inline.
| run: bash test.bash | ||
| working-directory: crates/fda | ||
| env: | ||
| FDA_BINARY: ${{ github.workspace }}/build/fda |
There was a problem hiding this comment.
These 51 lines (fda binary download + API key creation + CLI test step) are new additions, not part of reverting commit 60b70a9. That commit only added 8 lines to this file (related to artifact run-id inputs). This is new functionality inside a PR titled "Revert".
| name: pipeline-manager-${{ matrix.rust_target }} | ||
| path: build | ||
|
|
||
| - name: Download Compiler Binaries |
There was a problem hiding this comment.
The original commit 60b70a9 added run-id / github-token commented-out lines to this file. Removing those comments and instead adding a separate pipeline-manager download step is not reverting those changes — it is restructuring them. If that's intentional, the PR description should say so.
Signed-off-by: Jyotshna Yaparla <jyotshna.yaparla@feldera.com>
This reverts commit 60b70a9.
Fixes #5893
The artifact-caching logic caused downstream jobs to pick up 'skipped' status from build jobs when cancelled, allowing them to proceed instead of stopping.
This will be re-applied once a proper fix is in place.