Skip to content

Revert "ci: skip build phases on re-enqueue if artifacts already exist" #5974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jyotshnayaparla-00 wants to merge 2 commits into from
Closed

Revert "ci: skip build phases on re-enqueue if artifacts already exist" #5974

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f952441
Revert "ci: skip build phases on re-enqueue if artifacts already exist"
jyotshnayaparla-00 Apr 1, 2026
b154bdb
Merge branch 'main' into revert/ci-skip-build-on-reenqueue
jyotshnayaparla-00 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Revert "ci: skip build phases on re-enqueue if artifacts already exist" 
This reverts commit 60b70a9.
  • Loading branch information
@jyotshnayaparla-00
jyotshnayaparla-00 committed Apr 1, 2026
commit f952441059068a4cea4ce2a788a4fb299694f8a5
9 changes: 6 additions & 3 deletions .github/workflows/build-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,12 @@ jobs:
with:
name: feldera-binaries-${{ matrix.rust_target }}
path: build
#run-id: ${{ inputs.run-id }}
# Token is only needed when run-id is set
#github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Download pipeline-manager
uses: actions/download-artifact@v4
with:
name: pipeline-manager-${{ matrix.rust_target }}
path: build

- name: Download Compiler Binaries
Copy link
Copy Markdown

@mythical-fred mythical-fred Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original commit 60b70a9 added run-id / github-token commented-out lines to this file. Removing those comments and instead adding a separate pipeline-manager download step is not reverting those changes — it is restructuring them. If that's intentional, the PR description should say so.

uses: actions/download-artifact@v4
Expand Down
51 changes: 51 additions & 0 deletions .github/workflows/test-integration-platform.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,3 +230,54 @@ jobs:
OIDC_TEST_CLIENT_SECRET: ${{ secrets.OIDC_TEST_CLIENT_SECRET }}
OIDC_TEST_USERNAME: ${{ secrets.OIDC_TEST_USERNAME }}
OIDC_TEST_PASSWORD: ${{ secrets.OIDC_TEST_PASSWORD }}

- name: Download fda binary
uses: actions/download-artifact@v4
with:
name: fda-${{ matrix.target }}
path: build

# Remove if https://github.com/actions/upload-artifact/issues/38 ever gets fixed
- name: Make fda binary executable
run: chmod +x ./build/fda

- name: Create API key for CLI tests
if: ${{ vars.CI_DRY_RUN != 'true' }}
shell: bash
run: |
set -euo pipefail
API_KEY=$(uv run --locked python - <<'PY'
import os
import uuid
from feldera import FelderaClient
from feldera.testutils_oidc import setup_token_cache
import contextlib
import io

host = os.environ.get("FELDERA_HOST", "https://localhost:8080")
name = f"ci-fda-cli-{os.environ.get('GITHUB_RUN_ID', 'local')}-{uuid.uuid4().hex[:8]}"

token = None
if os.environ.get("OIDC_TEST_ISSUER") and os.environ.get("OIDC_TEST_CLIENT_ID"):
# Suppress auth helper output to keep GITHUB_ENV clean
with contextlib.redirect_stdout(io.StringIO()):
token_data = setup_token_cache()
if token_data is not None:
token = token_data.get("access_token")

client = FelderaClient(url=host, api_key=token)
resp = client.create_api_key(name)
print(resp["api_key"])
PY
)
echo "FELDERA_API_KEY=$API_KEY" >> "$GITHUB_ENV"
working-directory: python
env:
PYTHONPATH: ${{ github.workspace }}/python

- name: Run fda CLI tests
if: ${{ vars.CI_DRY_RUN != 'true' }}
run: bash test.bash
working-directory: crates/fda
env:
FDA_BINARY: ${{ github.workspace }}/build/fda
Copy link
Copy Markdown

@mythical-fred mythical-fred Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 51 lines (fda binary download + API key creation + CLI test step) are new additions, not part of reverting commit 60b70a9. That commit only added 8 lines to this file (related to artifact run-id inputs). This is new functionality inside a PR titled "Revert".

4 changes: 2 additions & 2 deletions .github/workflows/test-unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
uses: actions/download-artifact@v4
with:
name: feldera-sql-compiler
path: build
path: sql-build

# Remove if https://github.com/actions/upload-artifact/issues/38 ever gets fixed
- name: Make binaries executable
Expand All @@ -49,7 +49,7 @@ jobs:
- name: Copy feldera-sql-compiler JAR
run: |
mkdir -p sql-to-dbsp-compiler/SQL-compiler/target
cp build/sql2dbsp-jar-with-dependencies.jar sql-to-dbsp-compiler/SQL-compiler/target
cp sql-build/sql2dbsp-jar-with-dependencies.jar sql-to-dbsp-compiler/SQL-compiler/target

- name: Python SDK unit-tests
if: ${{ vars.CI_DRY_RUN != 'true' }}
Expand Down