Skip to content

ci: abort web console e2e job when workflow is cancelled#6012

Merged
jyotshnayaparla-00 merged 1 commit intomainfrom
fix-web-console-e2e-cancel
Apr 8, 2026
Merged

ci: abort web console e2e job when workflow is cancelled#6012
jyotshnayaparla-00 merged 1 commit intomainfrom
fix-web-console-e2e-cancel

Conversation

@jyotshnayaparla-00
Copy link
Copy Markdown
Contributor

Remove always() and the result == 'skipped' condition from invoke-tests-web-console-e2e.

Previously, the job had if: always() && (result == 'success' || result == 'skipped'), which was designed to handle the case where Docker build could be legitimately skipped (when artifacts already existed from a prior run). That logic was part of the artifact-caching feature reverted in #5974 .

Without that feature, Docker is never legitimately skipped, it only gets skipped when an upstream job is cancelled.

The always() condition caused e2e tests to keep running even after the workflow was cancelled. Removing the if: entirely means e2e only runs when Docker actually succeeds, and aborts with the rest of the workflow on cancellation.

@jyotshnayaparla-00 jyotshnayaparla-00 self-assigned this Apr 8, 2026
@jyotshnayaparla-00 jyotshnayaparla-00 requested a review from gz April 8, 2026 16:52
@jyotshnayaparla-00 jyotshnayaparla-00 added this pull request to the merge queue Apr 8, 2026
Copy link
Copy Markdown

@mythical-fred mythical-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into main with commit 39c178c Apr 8, 2026
1 check passed
@jyotshnayaparla-00 jyotshnayaparla-00 deleted the fix-web-console-e2e-cancel branch April 8, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants