Repository navigation
Conversation
…east-dev#7035) The feature view endpoints returned spec.project as null because the registry proto spec never carries it. Fill it in from the project each feature view was read from. Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7037 +/- ##
=======================================
Coverage 50.98% 50.99%
=======================================
Files 455 455
Lines 56990 56994 +4
Branches 8320 8321 +1
=======================================
+ Hits 29059 29063 +4
Misses 25946 25946
Partials 1985 1985
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…I app FastAPI does not define these arguments; they were only accepted through **extra and had no effect, and newer FastAPI releases fail mypy on them. Signed-off-by: Nick Quinn <nicholas_quinn@apple.com> (cherry picked from commit e9ef66d18d296c9f2ccce5bdff6f05db41c5a3ff) (cherry picked from commit f5b1dd8ccb4fe48704223e93cc4fd072ebd923f3)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…7035)
The feature view endpoints returned spec.project as null because the registry proto spec never carries it. Fill it in from the project each feature view was read from.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Checks
git commit -s)Testing Strategy
Misc