Skip to content

fix: Populate spec.project in registry REST feature view responses (#… - #7037

Open
nquinn408 wants to merge 1 commit into
feast-dev:masterfrom
nquinn408:feature-view-spec-project
Open

nquinn408 wants to merge 1 commit into
feast-dev:masterfrom
nquinn408:feature-view-spec-project

Conversation

@nquinn408

Copy link
Copy Markdown
Contributor

…7035)

The feature view endpoints returned spec.project as null because the registry proto spec never carries it. Fill it in from the project each feature view was read from.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc

…east-dev#7035)

The feature view endpoints returned spec.project as null because the
registry proto spec never carries it. Fill it in from the project each
feature view was read from.

Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
@nquinn408 nquinn408 self-assigned this Oct 18, 2026
@nquinn408
nquinn408 requested a review from a team as a code owner October 18, 2026 21:31
@codecov-commenter

codecov-commenter commented Oct 18, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.99%. Comparing base (7903e2e) to head (8981102).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7037   +/-   ##
=======================================
  Coverage   50.98%   50.99%           
=======================================
  Files         455      455           
  Lines       56990    56994    +4     
  Branches     8320     8321    +1     
=======================================
+ Hits        29059    29063    +4     
  Misses      25946    25946           
  Partials     1985     1985           
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 52.45% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...dk/python/feast/api/registry/rest/feature_views.py 73.57% <100.00%> (+0.55%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7903e2e...8981102. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants