Skip to content

Populate project in feature view spec (spec.project is null)" #7035

Open

Description

@nquinn408

Expected Behavior

GET /feature_views/all should populate spec.project in each feature view's spec, matching the top-level project field.

{
  "type": "featureView",
  "project": "project_a",
  "spec": {
    "name": "view_1",
    "project": "project_a",
    "entities": ["id"]
  }
}

Current Behavior

spec.project is null, even though the top-level project is set. Consumers that read the project from the spec get nothing.

{
  "type": "featureView",
  "project": "project_a",
  "spec": {
    "name": "view_1",
    "project": null,
    "entities": ["id"]
  }
}

Steps to reproduce

  1. Start the registry REST server with a registry that contains a feature view view_1 in project project_a.
  2. Query the feature views:
curl -s "http://localhost:6572/feature_views/all?allow_cache=false&limit=100" \
  | jq '.featureViews[] | select(.spec.name=="view_1") | {project, spec_project: .spec.project}'
  1. Observe {"project": "project_a", "spec_project": null}.

Specifications

  • Version:
  • Platform: <OS / Python version>
  • Subsystem: Registry server (REST API)

Possible Solution

Set spec.project from the view's project when building the REST response, or when the registry serializes the top-level project agree.

  • Placeholders: fill in Version and Platform yourself. I don't know which Feast release you're on or which envir in.
  • Where the fix goes: the Possible Solution is a guess. I haven't checked whether the gap is in the REST layer or in the proto conversion. Check that against the OSS code (~/Work/test/feast) before you file.
  • Port: I assumed 6572 for the REST server. Change it if your setup differs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions