Add pollingInterval config option#565
Merged
Merged
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
/retest |
1 similar comment
Collaborator
Author
|
/retest |
Collaborator
Author
|
/retest |
Member
|
/lgtm |
ches
reviewed
Mar 27, 2020
| options: {} | ||
| updates: | ||
| # Job update polling interval in milliseconds: how often Feast checks if new jobs should be sent to the runner. | ||
| pollingIntervalMillis: 60000 |
Member
There was a problem hiding this comment.
Spring has support for duration expressions to make these things more human-friendly, users could write pollingInterval: 1m.
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Apr 14, 2020
* Add pollingInterval config option * Add missing prefix * Increase polling interval
khorshuheng
pushed a commit
that referenced
this pull request
Apr 15, 2020
* Add pollingInterval config option * Add missing prefix * Increase polling interval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds config option for JobCoodinator polling interval, and shortens the interval for e2e tests to reduce flakiness of those tests.
Which issue(s) this PR fixes:
Fixes #531
Does this PR introduce a user-facing change?: