Add pollingInterval config option (#565)

Chen Zhiling · web-flow · commit 9facd2e5f00c · 2020-03-25T15:51:42.000+08:00
* Add pollingInterval config option

* Add missing prefix

* Increase polling interval
diff --git a/core/src/main/java/feast/core/config/FeastProperties.java b/core/src/main/java/feast/core/config/FeastProperties.java
@@ -45,6 +45,7 @@ public static class JobProperties {
   public static class JobUpdatesProperties {
 
     private long timeoutSeconds;
+    private long pollingIntervalMillis;
   }
 
   @Getter
diff --git a/core/src/main/java/feast/core/service/JobCoordinatorService.java b/core/src/main/java/feast/core/service/JobCoordinatorService.java
@@ -54,7 +54,6 @@
 @Service
 public class JobCoordinatorService {
 
-  private final long POLLING_INTERVAL_MILLISECONDS = 60000; // 1 min
   private JobRepository jobRepository;
   private FeatureSetRepository featureSetRepository;
   private SpecService specService;
@@ -87,7 +86,7 @@ public JobCoordinatorService(
    * <p>4) Updates Feature set statuses
    */
   @Transactional
-  @Scheduled(fixedDelay = POLLING_INTERVAL_MILLISECONDS)
+  @Scheduled(fixedDelayString = "${feast.jobs.updates.pollingIntervalMillis}")
   public void Poll() throws InvalidProtocolBufferException {
     log.info("Polling for new jobs...");
     List<JobUpdateTask> jobUpdateTasks = new ArrayList<>();
diff --git a/core/src/main/resources/application.yml b/core/src/main/resources/application.yml
@@ -31,6 +31,8 @@ feast:
     # Key-value dict of job options to be passed to the population jobs.
     options: {}
     updates:
+      # Job update polling interval in milliseconds: how often Feast checks if new jobs should be sent to the runner.
+      pollingIntervalMillis: 60000
       # Timeout in seconds for each attempt to update or submit a new job to the runner.
       timeoutSeconds: 240
     metrics:
diff --git a/infra/scripts/test-end-to-end-batch.sh b/infra/scripts/test-end-to-end-batch.sh
@@ -120,6 +120,7 @@ feast:
     runner: DirectRunner
     options: {}
     updates:
+      pollingIntervalMillis: 30000
       timeoutSeconds: 240
     metrics:
       enabled: false
diff --git a/infra/scripts/test-end-to-end.sh b/infra/scripts/test-end-to-end.sh
@@ -103,6 +103,7 @@ feast:
     runner: DirectRunner
     options: {}
     updates:
+      pollingIntervalMillis: 30000
       timeoutSeconds: 240
     metrics:
       enabled: false

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ public static class JobProperties {`
`45`	`45`	`public static class JobUpdatesProperties {`
`46`	`46`
`47`	`47`	`private long timeoutSeconds;`
	`48`	`+ private long pollingIntervalMillis;`
`48`	`49`	`}`
`49`	`50`
`50`	`51`	`@Getter`