Skip to content

Add pollingInterval config option #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 3 commits into from
Mar 25, 2020
Merged

Add pollingInterval config option #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a25833
Add pollingInterval config option
Mar 24, 2020
e00fbe0
Add missing prefix
Mar 24, 2020
aa374ae
Increase polling interval
Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/main/java/feast/core/config/FeastProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public static class JobProperties {
public static class JobUpdatesProperties {

private long timeoutSeconds;
private long pollingIntervalMillis;
}

@Getter
Expand Down
3 changes: 1 addition & 2 deletions core/src/main/java/feast/core/service/JobCoordinatorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
@Service
public class JobCoordinatorService {

private final long POLLING_INTERVAL_MILLISECONDS = 60000; // 1 min
private JobRepository jobRepository;
private FeatureSetRepository featureSetRepository;
private SpecService specService;
Expand Down Expand Up @@ -87,7 +86,7 @@ public JobCoordinatorService(
* <p>4) Updates Feature set statuses
*/
@Transactional
@Scheduled(fixedDelay = POLLING_INTERVAL_MILLISECONDS)
@Scheduled(fixedDelayString = "${feast.jobs.updates.pollingIntervalMillis}")
public void Poll() throws InvalidProtocolBufferException {
log.info("Polling for new jobs...");
List<JobUpdateTask> jobUpdateTasks = new ArrayList<>();
Expand Down
2 changes: 2 additions & 0 deletions core/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ feast:
# Key-value dict of job options to be passed to the population jobs.
options: {}
updates:
# Job update polling interval in milliseconds: how often Feast checks if new jobs should be sent to the runner.
pollingIntervalMillis: 60000
Copy link
Copy Markdown
Member

@ches ches Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spring has support for duration expressions to make these things more human-friendly, users could write pollingInterval: 1m.

# Timeout in seconds for each attempt to update or submit a new job to the runner.
timeoutSeconds: 240
metrics:
Expand Down
1 change: 1 addition & 0 deletions infra/scripts/test-end-to-end-batch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ feast:
runner: DirectRunner
options: {}
updates:
pollingIntervalMillis: 30000
timeoutSeconds: 240
metrics:
enabled: false
Expand Down
1 change: 1 addition & 0 deletions infra/scripts/test-end-to-end.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ feast:
runner: DirectRunner
options: {}
updates:
pollingIntervalMillis: 30000
timeoutSeconds: 240
metrics:
enabled: false
Expand Down