chore: Consolidate wheels/source builds & artifacts for release - #5119
Conversation
|
@franciscojavierarceo in troubleshooting this fix... i'm realizing the |
|
@franciscojavierarceo scratch that ... i see we're building the dev images for pre-release. all good. |
Yeah, that I had made sure of. |
31d290b to
a815a47
Compare
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
|
@tokoko do you know why we were using a macos runner to separately handle our sdist build? |
| with: | ||
| python-version: "3.11" | ||
| architecture: x64 | ||
| - name: Setup Node |
There was a problem hiding this comment.
we don't need to setup node?
There was a problem hiding this comment.
yes, but we're consolidating and it's already being set in the new job
There was a problem hiding this comment.
check line # 41
There was a problem hiding this comment.
oh duh, nice thank you
|
@tchughesiv nope, it was macos from the get-go, shouldn't make a difference one way or the other. I suspect the point of a separate job was simply to run it in parallel. |
|
@tchughesiv the local integration tests ran for like 5+ hours so I just merged it...that sounds like something we should look into. |
What this PR does / why we need it:
Since the
0.42.0release, our workflow has no longer been uploading the sdist tarball to PyPi. This PR aims to fix this by consolidating the wheels and source builds to a single job and uploading said artifacts to the same temp storage which feeds the PyPi upload job.It's worth noting that the separate source job appears to have previously been created to resolve some issues that the
make install-go-ci-dependencieswas causing. This make command is no longer in use as it has since been commented out.feast/Makefile
Lines 649 to 651 in 75f5a90