Skip to content

Commit 9f190ef

Browse files
committed
consolidate wheels/source builds & artifacts for release
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
1 parent 24d5db6 commit 9f190ef

1 file changed

Lines changed: 8 additions & 45 deletions

File tree

.github/workflows/build_wheels.yml

Lines changed: 8 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ on:
2929

3030
jobs:
3131
build-python-wheel:
32-
name: Build wheels
32+
name: Build wheels and source
3333
runs-on: ubuntu-latest
3434
steps:
3535
- uses: actions/checkout@v4
@@ -43,73 +43,36 @@ jobs:
4343
with:
4444
node-version-file: './ui/.nvmrc'
4545
registry-url: 'https://registry.npmjs.org'
46-
- name: Build UI
47-
run: make build-ui
4846
- id: get-version
4947
uses: ./.github/actions/get-semantic-release-version
5048
with:
5149
custom_version: ${{ github.event.inputs.custom_version }}
5250
token: ${{ github.event.inputs.token }}
53-
- name: Build wheels
51+
- name: Install dependencies and build ui
5452
env:
5553
VERSION: ${{ steps.get-version.outputs.release_version }}
5654
PYPI_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
57-
run: |
58-
git fetch --tags
59-
git checkout ${VERSION}
60-
python -m pip install build
61-
python -m build --wheel --outdir wheelhouse/
62-
- uses: actions/upload-artifact@v4
63-
with:
64-
name: python-wheels
65-
path: ./wheelhouse/*.whl
66-
67-
build-source-distribution:
68-
name: Build source distribution
69-
runs-on: macos-13
70-
steps:
71-
- uses: actions/checkout@v4
72-
- name: Setup Python
73-
id: setup-python
74-
uses: actions/setup-python@v5
75-
with:
76-
python-version: "3.11"
77-
architecture: x64
78-
- name: Setup Node
79-
uses: actions/setup-node@v3
80-
with:
81-
node-version-file: './ui/.nvmrc'
82-
registry-url: 'https://registry.npmjs.org'
83-
- id: get-version
84-
uses: ./.github/actions/get-semantic-release-version
85-
with:
86-
custom_version: ${{ github.event.inputs.custom_version }}
87-
token: ${{ github.event.inputs.token }}
88-
- name: Build and install dependencies
89-
env:
90-
VERSION: ${{ steps.get-version.outputs.release_version }}
9155
# There's a `git restore` in here because `make install-go-ci-dependencies` is actually messing up go.mod & go.sum.
9256
run: |
9357
git fetch --tags
9458
git checkout ${VERSION}
95-
pip install -U pip setuptools wheel twine
59+
pip install -U pip setuptools wheel build
9660
make build-ui
9761
git status
9862
git restore go.mod go.sum
9963
git restore sdk/python/feast/ui/yarn.lock
100-
- name: Build
101-
run: |
102-
python3 setup.py sdist
64+
- name: Build feast
65+
run: python -m build
10366
- uses: actions/upload-artifact@v4
10467
with:
105-
name: source-distribution
68+
name: python-wheels
10669
path: dist/*
10770

10871
# We add this step so the docker images can be built as part of the pre-release verification steps.
10972
build-docker-images:
11073
name: Build Docker images
11174
runs-on: ubuntu-latest
112-
needs: [ build-python-wheel, build-source-distribution ]
75+
needs: [ build-python-wheel ]
11376
strategy:
11477
matrix:
11578
component: [ feature-server-dev, feature-server-java, feature-transformation-server, feast-operator ]
@@ -137,7 +100,7 @@ jobs:
137100
verify-python-wheels:
138101
name: Verify Python wheels
139102
runs-on: ${{ matrix.os }}
140-
needs: [ build-python-wheel, build-source-distribution ]
103+
needs: [ build-python-wheel ]
141104
strategy:
142105
matrix:
143106
os: [ ubuntu-latest, macos-13 ]

0 commit comments

Comments
 (0)