Skip to content

chore: Consolidate wheels/source builds & artifacts for release #5119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Mar 5, 2025
Merged

chore: Consolidate wheels/source builds & artifacts for release #5119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 6 additions & 50 deletions .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ on:

jobs:
build-python-wheel:
name: Build wheels
name: Build wheels and source
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -50,66 +50,26 @@ jobs:
with:
custom_version: ${{ github.event.inputs.custom_version }}
token: ${{ github.event.inputs.token }}
- name: Build wheels
- name: Checkout version and install dependencies
env:
VERSION: ${{ steps.get-version.outputs.release_version }}
PYPI_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
run: |
git fetch --tags
git checkout ${VERSION}
python -m pip install build
python -m build --wheel --outdir wheelhouse/
- name: Build feast
run: python -m build
- uses: actions/upload-artifact@v4
with:
name: python-wheels
path: ./wheelhouse/*.whl

build-source-distribution:
name: Build source distribution
runs-on: macos-13
steps:
- uses: actions/checkout@v4
- name: Setup Python
id: setup-python
uses: actions/setup-python@v5
with:
python-version: "3.11"
architecture: x64
- name: Setup Node

@franciscojavierarceo franciscojavierarceo Mar 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to setup node?

@tchughesiv tchughesiv Mar 5, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but we're consolidating and it's already being set in the new job

@tchughesiv tchughesiv Mar 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check line # 41

@franciscojavierarceo franciscojavierarceo Mar 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh duh, nice thank you

uses: actions/setup-node@v3
with:
node-version-file: './ui/.nvmrc'
registry-url: 'https://registry.npmjs.org'
- id: get-version
uses: ./.github/actions/get-semantic-release-version
with:
custom_version: ${{ github.event.inputs.custom_version }}
token: ${{ github.event.inputs.token }}
- name: Build and install dependencies
env:
VERSION: ${{ steps.get-version.outputs.release_version }}
# There's a `git restore` in here because `make install-go-ci-dependencies` is actually messing up go.mod & go.sum.
run: |
git fetch --tags
git checkout ${VERSION}
pip install -U pip setuptools wheel twine
make build-ui
git status
git restore go.mod go.sum
git restore sdk/python/feast/ui/yarn.lock
- name: Build
run: |
python3 setup.py sdist
Comment thread
redhatHameed marked this conversation as resolved.
- uses: actions/upload-artifact@v4
with:
name: source-distribution
path: dist/*

# We add this step so the docker images can be built as part of the pre-release verification steps.
build-docker-images:
name: Build Docker images
runs-on: ubuntu-latest
needs: [ build-python-wheel, build-source-distribution ]
needs: [ build-python-wheel ]
strategy:
matrix:
component: [ feature-server-dev, feature-server-java, feature-transformation-server, feast-operator ]
Expand Down Expand Up @@ -137,7 +97,7 @@ jobs:
verify-python-wheels:
name: Verify Python wheels
runs-on: ${{ matrix.os }}
needs: [ build-python-wheel, build-source-distribution ]
needs: [ build-python-wheel ]
strategy:
matrix:
os: [ ubuntu-latest, macos-13 ]
Expand Down Expand Up @@ -168,10 +128,6 @@ jobs:
with:
name: python-wheels
path: dist
- uses: actions/download-artifact@v4.1.7
with:
name: source-distribution
path: dist
- name: Install OS X dependencies
if: matrix.os == 'macos-13'
run: brew install coreutils
Expand Down