Skip to content

chore: Bump deprecation version from 0.23 to 0.24 - #2805

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
felixwang9817:bump_deprecation
Jun 17, 2022
Merged

chore: Bump deprecation version from 0.23 to 0.24#2805
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
felixwang9817:bump_deprecation

Conversation

@felixwang9817

Copy link
Copy Markdown
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: This PR bumps the deprecation of all Feast object parameters, and related logic, from 0.23 to 0.24.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter

codecov-commenter commented Jun 17, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2805 (c07a54a) into master (a06700d) will increase coverage by 20.28%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2805       +/-   ##
===========================================
+ Coverage   59.67%   79.96%   +20.28%     
===========================================
  Files         172      172               
  Lines       15311    15509      +198     
===========================================
+ Hits         9137    12401     +3264     
+ Misses       6174     3108     -3066     
Flag Coverage Δ
integrationtests 70.55% <ø> (?)
unittests 59.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/cli.py 39.49% <ø> (ø)
sdk/python/feast/data_source.py 83.70% <ø> (+0.55%) ⬆️
sdk/python/feast/diff/registry_diff.py 69.28% <ø> (ø)
sdk/python/feast/entity.py 90.00% <ø> (ø)
sdk/python/feast/feature_service.py 94.00% <ø> (+9.00%) ⬆️
sdk/python/feast/feature_store.py 86.16% <ø> (+17.23%) ⬆️
sdk/python/feast/feature_view.py 88.82% <ø> (+5.31%) ⬆️
...thon/feast/infra/offline_stores/bigquery_source.py 87.50% <ø> (+25.00%) ⬆️
...stores/contrib/spark_offline_store/spark_source.py 61.15% <ø> (ø)
...k/python/feast/infra/offline_stores/file_source.py 88.07% <ø> (+11.92%) ⬆️
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06700d...c07a54a. Read the comment docs.

@feast-ci-bot
feast-ci-bot merged commit 6b4e8d0 into feast-dev:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants