Bump deprecation version from 0.23 to 0.24

felixwang9817 · felixwang9817 · commit c07a54afea9b · 2022-06-16T15:10:49.000-07:00
Signed-off-by: Felix Wang &lt;wangfelix98@gmail.com&gt;
diff --git a/sdk/python/feast/cli.py b/sdk/python/feast/cli.py
@@ -196,7 +196,7 @@ def data_source_describe(ctx: click.Context, name: str):
 
     warnings.warn(
         "Describing data sources will only work properly if all data sources have names or table names specified. "
-        "Starting Feast 0.23, data source unique names will be required to encourage data source discovery.",
+        "Starting Feast 0.24, data source unique names will be required to encourage data source discovery.",
         RuntimeWarning,
     )
     print(
@@ -223,7 +223,7 @@ def data_source_list(ctx: click.Context):
 
     warnings.warn(
         "Listing data sources will only work properly if all data sources have names or table names specified. "
-        "Starting Feast 0.23, data source unique names will be required to encourage data source discovery",
+        "Starting Feast 0.24, data source unique names will be required to encourage data source discovery",
         RuntimeWarning,
     )
     print(tabulate(table, headers=["NAME", "CLASS"], tablefmt="plain"))
diff --git a/sdk/python/feast/data_source.py b/sdk/python/feast/data_source.py
@@ -239,7 +239,7 @@ def __init__(
             warnings.warn(
                 (
                     "Names for data sources need to be supplied. "
-                    "Data sources without names will not be supported after Feast 0.23."
+                    "Data sources without names will not be supported after Feast 0.24."
                 ),
                 UserWarning,
             )
@@ -248,7 +248,7 @@ def __init__(
             warnings.warn(
                 (
                     "The argument 'event_timestamp_column' is being deprecated. Please use 'timestamp_field' instead. "
-                    "instead. Feast 0.23 and onwards will not support the argument 'event_timestamp_column' for datasources."
+                    "instead. Feast 0.24 and onwards will not support the argument 'event_timestamp_column' for datasources."
                 ),
                 DeprecationWarning,
             )
@@ -431,7 +431,7 @@ def __init__(
             warnings.warn(
                 (
                     "Kafka parameters should be specified as a keyword argument instead of a positional arg."
-                    "Feast 0.23+ will not support positional arguments to construct Kafka sources"
+                    "Feast 0.24+ will not support positional arguments to construct Kafka sources"
                 ),
                 DeprecationWarning,
             )
@@ -592,7 +592,7 @@ def __init__(
             warnings.warn(
                 (
                     "Request source parameters should be specified as a keyword argument instead of a positional arg."
-                    "Feast 0.23+ will not support positional arguments to construct request sources"
+                    "Feast 0.24+ will not support positional arguments to construct request sources"
                 ),
                 DeprecationWarning,
             )
@@ -611,7 +611,7 @@ def __init__(
             raise ValueError("Schema needs to be provided for Request Source")
         if isinstance(_schema, Dict):
             warnings.warn(
-                "Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.23. "
+                "Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.24. "
                 "Please use List[Field] instead for the schema",
                 DeprecationWarning,
             )
@@ -663,7 +663,7 @@ def from_proto(data_source: DataSourceProto):
 
         if deprecated_schema and not schema_pb:
             warnings.warn(
-                "Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.23. "
+                "Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.24. "
                 "Please use List[Field] instead for the schema",
                 DeprecationWarning,
             )
@@ -724,7 +724,7 @@ def source_datatype_to_feast_value_type() -> Callable[[str], ValueType]:
 class RequestDataSource(RequestSource):
     def __init__(self, *args, **kwargs):
         warnings.warn(
-            "The 'RequestDataSource' class is deprecated and was renamed to RequestSource. Please use RequestSource instead. This class name will be removed in Feast 0.23.",
+            "The 'RequestDataSource' class is deprecated and was renamed to RequestSource. Please use RequestSource instead. This class name will be removed in Feast 0.24.",
             DeprecationWarning,
         )
         super().__init__(*args, **kwargs)
@@ -803,7 +803,7 @@ def __init__(
             warnings.warn(
                 (
                     "Kinesis parameters should be specified as a keyword argument instead of a positional arg."
-                    "Feast 0.23+ will not support positional arguments to construct kinesis sources"
+                    "Feast 0.24+ will not support positional arguments to construct kinesis sources"
                 ),
                 DeprecationWarning,
             )
@@ -922,7 +922,7 @@ def __init__(
             warnings.warn(
                 (
                     "Push source parameters should be specified as a keyword argument instead of a positional arg."
-                    "Feast 0.23+ will not support positional arguments to construct push sources"
+                    "Feast 0.24+ will not support positional arguments to construct push sources"
                 ),
                 DeprecationWarning,
             )
diff --git a/sdk/python/feast/diff/registry_diff.py b/sdk/python/feast/diff/registry_diff.py
@@ -67,7 +67,7 @@ def to_string(self):
             if feast_object_diff.transition_type == TransitionType.UNCHANGED:
                 continue
             if feast_object_diff.feast_object_type == FeastObjectType.DATA_SOURCE:
-                # TODO(adchia): Print statements out starting in Feast 0.23
+                # TODO(adchia): Print statements out starting in Feast 0.24
                 continue
             action, color = message_action_map[feast_object_diff.transition_type]
             log_string += f"{action} {feast_object_diff.feast_object_type.value} {Style.BRIGHT + color}{feast_object_diff.name}{Style.RESET_ALL}\n"
diff --git a/sdk/python/feast/entity.py b/sdk/python/feast/entity.py
@@ -90,7 +90,7 @@ def __init__(
             warnings.warn(
                 (
                     "Entity name should be specified as a keyword argument instead of a positional arg."
-                    "Feast 0.23+ will not support positional arguments to construct Entities"
+                    "Feast 0.24+ will not support positional arguments to construct Entities"
                 ),
                 DeprecationWarning,
             )
@@ -108,7 +108,7 @@ def __init__(
             warnings.warn(
                 (
                     "The `value_type` parameter is being deprecated. Instead, the type of an entity "
-                    "should be specified as a Field in the schema of a feature view. Feast 0.23 and "
+                    "should be specified as a Field in the schema of a feature view. Feast 0.24 and "
                     "onwards will not support the `value_type` parameter. The `entities` parameter of "
                     "feature views should also be changed to a List[Entity] instead of a List[str]; if "
                     "this is not done, entity columns will be mistakenly interpreted as feature columns."
@@ -125,7 +125,7 @@ def __init__(
             warnings.warn(
                 (
                     "The `join_key` parameter is being deprecated in favor of the `join_keys` parameter. "
-                    "Please switch from using `join_key` to `join_keys`. Feast 0.23 and onwards will not "
+                    "Please switch from using `join_key` to `join_keys`. Feast 0.24 and onwards will not "
                     "support the `join_key` parameter."
                 ),
                 DeprecationWarning,
diff --git a/sdk/python/feast/feature_service.py b/sdk/python/feast/feature_service.py
@@ -72,7 +72,7 @@ def __init__(
             warnings.warn(
                 (
                     "Feature service parameters should be specified as a keyword argument instead of a positional arg."
-                    "Feast 0.23+ will not support positional arguments to construct feature service"
+                    "Feast 0.24+ will not support positional arguments to construct feature service"
                 ),
                 DeprecationWarning,
             )
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -2504,7 +2504,7 @@ def _validate_data_sources(data_sources: List[DataSource]):
                     f"More than one data source with name {case_insensitive_ds_name} found. "
                     f"Please ensure that all data source names are case-insensitively unique. "
                     f"It may be necessary to ignore certain files in your feature repository by using a .feastignore "
-                    f"file. Starting in Feast 0.23, unique names (perhaps inferred from the table name) will be "
+                    f"file. Starting in Feast 0.24, unique names (perhaps inferred from the table name) will be "
                     f"required in data sources to encourage data source discovery"
                 )
         else:
diff --git a/sdk/python/feast/feature_view.py b/sdk/python/feast/feature_view.py
@@ -148,7 +148,7 @@ def __init__(
             warnings.warn(
                 (
                     "feature view parameters should be specified as a keyword argument instead of a positional arg."
-                    "Feast 0.23+ will not support positional arguments to construct feature views"
+                    "Feast 0.24+ will not support positional arguments to construct feature views"
                 ),
                 DeprecationWarning,
             )
@@ -178,7 +178,7 @@ def __init__(
             warnings.warn(
                 (
                     "The `entities` parameter should be a list of `Entity` objects. "
-                    "Feast 0.23 and onwards will not support passing in a list of "
+                    "Feast 0.24 and onwards will not support passing in a list of "
                     "strings to define entities."
                 ),
                 DeprecationWarning,
@@ -191,7 +191,7 @@ def __init__(
             warnings.warn(
                 (
                     "The option to pass a Duration object to the ttl parameter is being deprecated. "
-                    "Please pass a timedelta object instead. Feast 0.23 and onwards will not support "
+                    "Please pass a timedelta object instead. Feast 0.24 and onwards will not support "
                     "Duration objects."
                 ),
                 DeprecationWarning,
@@ -206,7 +206,7 @@ def __init__(
                 (
                     "The `features` parameter is being deprecated in favor of the `schema` parameter. "
                     "Please switch from using `features` to `schema`. This will also requiring switching "
-                    "feature definitions from using `Feature` to `Field`. Feast 0.23 and onwards will not "
+                    "feature definitions from using `Feature` to `Field`. Feast 0.24 and onwards will not "
                     "support the `features` parameter."
                 ),
                 DeprecationWarning,
@@ -282,7 +282,7 @@ def _initialize_sources(self, name, batch_source, stream_source, source):
         else:
             warnings.warn(
                 "batch_source and stream_source have been deprecated in favor of `source`."
-                "The deprecated fields will be removed in Feast 0.23.",
+                "The deprecated fields will be removed in Feast 0.24.",
                 DeprecationWarning,
             )
             if stream_source is not None and isinstance(stream_source, PushSource):
diff --git a/sdk/python/feast/infra/offline_stores/bigquery_source.py b/sdk/python/feast/infra/offline_stores/bigquery_source.py
@@ -63,7 +63,7 @@ def __init__(
             warnings.warn(
                 (
                     "The argument 'date_partition_column' is not supported for BigQuery sources. "
-                    "It will be removed in Feast 0.23+"
+                    "It will be removed in Feast 0.24+"
                 ),
                 DeprecationWarning,
             )
@@ -76,7 +76,7 @@ def __init__(
             else:
                 warnings.warn(
                     (
-                        f"Starting in Feast 0.23, Feast will require either a name for a data source (if using query) or `table`: {self.query}"
+                        f"Starting in Feast 0.24, Feast will require either a name for a data source (if using query) or `table`: {self.query}"
                     ),
                     DeprecationWarning,
                 )
diff --git a/sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py b/sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py
@@ -59,7 +59,7 @@ def __init__(
             warnings.warn(
                 (
                     "The argument 'date_partition_column' is not supported for Spark sources."
-                    "It will be removed in Feast 0.23+"
+                    "It will be removed in Feast 0.24+"
                 ),
                 DeprecationWarning,
             )
diff --git a/sdk/python/feast/infra/offline_stores/file_source.py b/sdk/python/feast/infra/offline_stores/file_source.py
@@ -70,7 +70,7 @@ def __init__(
                 warnings.warn(
                     (
                         "File Source parameters should be specified as a keyword argument instead of a positional arg."
-                        "Feast 0.23+ will not support positional arguments to construct File sources"
+                        "Feast 0.24+ will not support positional arguments to construct File sources"
                     ),
                     DeprecationWarning,
                 )
@@ -95,7 +95,7 @@ def __init__(
             warnings.warn(
                 (
                     "The argument 'date_partition_column' is not supported for File sources."
-                    "It will be removed in Feast 0.23+"
+                    "It will be removed in Feast 0.24+"
                 ),
                 DeprecationWarning,
             )
diff --git a/sdk/python/feast/infra/offline_stores/redshift_source.py b/sdk/python/feast/infra/offline_stores/redshift_source.py
@@ -73,7 +73,7 @@ def __init__(
             else:
                 warnings.warn(
                     (
-                        f"Starting in Feast 0.23, Feast will require either a name for a data source (if using query) "
+                        f"Starting in Feast 0.24, Feast will require either a name for a data source (if using query) "
                         f"or `table`: {self.query}"
                     ),
                     DeprecationWarning,
@@ -82,7 +82,7 @@ def __init__(
             warnings.warn(
                 (
                     "The argument 'date_partition_column' is not supported for Redshift sources."
-                    "It will be removed in Feast 0.23+"
+                    "It will be removed in Feast 0.24+"
                 ),
                 DeprecationWarning,
             )
diff --git a/sdk/python/feast/infra/offline_stores/snowflake_source.py b/sdk/python/feast/infra/offline_stores/snowflake_source.py
@@ -79,7 +79,7 @@ def __init__(
             else:
                 warnings.warn(
                     (
-                        f"Starting in Feast 0.23, Feast will require either a name for a data source (if using query) "
+                        f"Starting in Feast 0.24, Feast will require either a name for a data source (if using query) "
                         f"or `table`: {self.query}"
                     ),
                     DeprecationWarning,
@@ -89,7 +89,7 @@ def __init__(
             warnings.warn(
                 (
                     "The argument 'date_partition_column' is not supported for Snowflake sources."
-                    "It will be removed in Feast 0.23+"
+                    "It will be removed in Feast 0.24+"
                 ),
                 DeprecationWarning,
             )
diff --git a/sdk/python/feast/on_demand_feature_view.py b/sdk/python/feast/on_demand_feature_view.py
diff --git a/sdk/python/tests/integration/registration/test_inference.py b/sdk/python/tests/integration/registration/test_inference.py
diff --git a/sdk/python/tests/integration/registration/test_registry.py b/sdk/python/tests/integration/registration/test_registry.py
diff --git a/sdk/python/tests/unit/test_data_sources.py b/sdk/python/tests/unit/test_data_sources.py

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ def __init__(`
`239`	`239`	`warnings.warn(`
`240`	`240`	`(`
`241`	`241`	`"Names for data sources need to be supplied. "`
`242`		`- "Data sources without names will not be supported after Feast 0.23."`
	`242`	`+ "Data sources without names will not be supported after Feast 0.24."`
`243`	`243`	`),`
`244`	`244`	`UserWarning,`
`245`	`245`	`)`
`@@ -248,7 +248,7 @@ def __init__(`
`248`	`248`	`warnings.warn(`
`249`	`249`	`(`
`250`	`250`	`"The argument 'event_timestamp_column' is being deprecated. Please use 'timestamp_field' instead. "`
`251`		`- "instead. Feast 0.23 and onwards will not support the argument 'event_timestamp_column' for datasources."`
	`251`	`+ "instead. Feast 0.24 and onwards will not support the argument 'event_timestamp_column' for datasources."`
`252`	`252`	`),`
`253`	`253`	`DeprecationWarning,`
`254`	`254`	`)`
`@@ -431,7 +431,7 @@ def __init__(`
`431`	`431`	`warnings.warn(`
`432`	`432`	`(`
`433`	`433`	`"Kafka parameters should be specified as a keyword argument instead of a positional arg."`
`434`		`- "Feast 0.23+ will not support positional arguments to construct Kafka sources"`
	`434`	`+ "Feast 0.24+ will not support positional arguments to construct Kafka sources"`
`435`	`435`	`),`
`436`	`436`	`DeprecationWarning,`
`437`	`437`	`)`
`@@ -592,7 +592,7 @@ def __init__(`
`592`	`592`	`warnings.warn(`
`593`	`593`	`(`
`594`	`594`	`"Request source parameters should be specified as a keyword argument instead of a positional arg."`
`595`		`- "Feast 0.23+ will not support positional arguments to construct request sources"`
	`595`	`+ "Feast 0.24+ will not support positional arguments to construct request sources"`
`596`	`596`	`),`
`597`	`597`	`DeprecationWarning,`
`598`	`598`	`)`
`@@ -611,7 +611,7 @@ def __init__(`
`611`	`611`	`raise ValueError("Schema needs to be provided for Request Source")`
`612`	`612`	`if isinstance(_schema, Dict):`
`613`	`613`	`warnings.warn(`
`614`		`- "Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.23. "`
	`614`	`+ "Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.24. "`
`615`	`615`	`"Please use List[Field] instead for the schema",`
`616`	`616`	`DeprecationWarning,`
`617`	`617`	`)`
`@@ -663,7 +663,7 @@ def from_proto(data_source: DataSourceProto):`
`663`	`663`
`664`	`664`	`if deprecated_schema and not schema_pb:`
`665`	`665`	`warnings.warn(`
`666`		`- "Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.23. "`
	`666`	`+ "Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.24. "`
`667`	`667`	`"Please use List[Field] instead for the schema",`
`668`	`668`	`DeprecationWarning,`
`669`	`669`	`)`
`@@ -724,7 +724,7 @@ def source_datatype_to_feast_value_type() -> Callable[[str], ValueType]:`
`724`	`724`	`class RequestDataSource(RequestSource):`
`725`	`725`	`def __init__(self, args, *kwargs):`
`726`	`726`	`warnings.warn(`
`727`		`- "The 'RequestDataSource' class is deprecated and was renamed to RequestSource. Please use RequestSource instead. This class name will be removed in Feast 0.23.",`
	`727`	`+ "The 'RequestDataSource' class is deprecated and was renamed to RequestSource. Please use RequestSource instead. This class name will be removed in Feast 0.24.",`
`728`	`728`	`DeprecationWarning,`
`729`	`729`	`)`
`730`	`730`	`super().__init__(args, *kwargs)`
`@@ -803,7 +803,7 @@ def __init__(`
`803`	`803`	`warnings.warn(`
`804`	`804`	`(`
`805`	`805`	`"Kinesis parameters should be specified as a keyword argument instead of a positional arg."`
`806`		`- "Feast 0.23+ will not support positional arguments to construct kinesis sources"`
	`806`	`+ "Feast 0.24+ will not support positional arguments to construct kinesis sources"`
`807`	`807`	`),`
`808`	`808`	`DeprecationWarning,`
`809`	`809`	`)`
`@@ -922,7 +922,7 @@ def __init__(`
`922`	`922`	`warnings.warn(`
`923`	`923`	`(`
`924`	`924`	`"Push source parameters should be specified as a keyword argument instead of a positional arg."`
`925`		`- "Feast 0.23+ will not support positional arguments to construct push sources"`
	`925`	`+ "Feast 0.24+ will not support positional arguments to construct push sources"`
`926`	`926`	`),`
`927`	`927`	`DeprecationWarning,`
`928`	`928`	`)`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ def __init__(`
`72`	`72`	`warnings.warn(`
`73`	`73`	`(`
`74`	`74`	`"Feature service parameters should be specified as a keyword argument instead of a positional arg."`
`75`		`- "Feast 0.23+ will not support positional arguments to construct feature service"`
	`75`	`+ "Feast 0.24+ will not support positional arguments to construct feature service"`
`76`	`76`	`),`
`77`	`77`	`DeprecationWarning,`
`78`	`78`	`)`
Original file line number	Diff line number	Diff line change
`@@ -2504,7 +2504,7 @@ def _validate_data_sources(data_sources: List[DataSource]):`
`2504`	`2504`	`f"More than one data source with name {case_insensitive_ds_name} found. "`
`2505`	`2505`	`f"Please ensure that all data source names are case-insensitively unique. "`
`2506`	`2506`	`f"It may be necessary to ignore certain files in your feature repository by using a .feastignore "`
`2507`		`- f"file. Starting in Feast 0.23, unique names (perhaps inferred from the table name) will be "`
	`2507`	`+ f"file. Starting in Feast 0.24, unique names (perhaps inferred from the table name) will be "`
`2508`	`2508`	`f"required in data sources to encourage data source discovery"`
`2509`	`2509`	`)`
`2510`	`2510`	`else:`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ def __init__(`
`63`	`63`	`warnings.warn(`
`64`	`64`	`(`
`65`	`65`	`"The argument 'date_partition_column' is not supported for BigQuery sources. "`
`66`		`- "It will be removed in Feast 0.23+"`
	`66`	`+ "It will be removed in Feast 0.24+"`
`67`	`67`	`),`
`68`	`68`	`DeprecationWarning,`
`69`	`69`	`)`
`@@ -76,7 +76,7 @@ def __init__(`
`76`	`76`	`else:`
`77`	`77`	`warnings.warn(`
`78`	`78`	`(`
`79`		- f"Starting in Feast 0.23, Feast will require either a name for a data source (if using query) or `table`: {self.query}"
	`79`	+ f"Starting in Feast 0.24, Feast will require either a name for a data source (if using query) or `table`: {self.query}"
`80`	`80`	`),`
`81`	`81`	`DeprecationWarning,`
`82`	`82`	`)`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ def __init__(`
`59`	`59`	`warnings.warn(`
`60`	`60`	`(`
`61`	`61`	`"The argument 'date_partition_column' is not supported for Spark sources."`
`62`		`- "It will be removed in Feast 0.23+"`
	`62`	`+ "It will be removed in Feast 0.24+"`
`63`	`63`	`),`
`64`	`64`	`DeprecationWarning,`
`65`	`65`	`)`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ def __init__(`
`70`	`70`	`warnings.warn(`
`71`	`71`	`(`
`72`	`72`	`"File Source parameters should be specified as a keyword argument instead of a positional arg."`
`73`		`- "Feast 0.23+ will not support positional arguments to construct File sources"`
	`73`	`+ "Feast 0.24+ will not support positional arguments to construct File sources"`
`74`	`74`	`),`
`75`	`75`	`DeprecationWarning,`
`76`	`76`	`)`
`@@ -95,7 +95,7 @@ def __init__(`
`95`	`95`	`warnings.warn(`
`96`	`96`	`(`
`97`	`97`	`"The argument 'date_partition_column' is not supported for File sources."`
`98`		`- "It will be removed in Feast 0.23+"`
	`98`	`+ "It will be removed in Feast 0.24+"`
`99`	`99`	`),`
`100`	`100`	`DeprecationWarning,`
`101`	`101`	`)`