Skip to content

chore: Bump deprecation version from 0.23 to 0.24 #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Jun 17, 2022
Merged

chore: Bump deprecation version from 0.23 to 0.24 #2805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/python/feast/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def data_source_describe(ctx: click.Context, name: str):

warnings.warn(
"Describing data sources will only work properly if all data sources have names or table names specified. "
"Starting Feast 0.23, data source unique names will be required to encourage data source discovery.",
"Starting Feast 0.24, data source unique names will be required to encourage data source discovery.",
RuntimeWarning,
)
print(
Expand All @@ -223,7 +223,7 @@ def data_source_list(ctx: click.Context):

warnings.warn(
"Listing data sources will only work properly if all data sources have names or table names specified. "
"Starting Feast 0.23, data source unique names will be required to encourage data source discovery",
"Starting Feast 0.24, data source unique names will be required to encourage data source discovery",
RuntimeWarning,
)
print(tabulate(table, headers=["NAME", "CLASS"], tablefmt="plain"))
Expand Down
18 changes: 9 additions & 9 deletions sdk/python/feast/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def __init__(
warnings.warn(
(
"Names for data sources need to be supplied. "
"Data sources without names will not be supported after Feast 0.23."
"Data sources without names will not be supported after Feast 0.24."
),
UserWarning,
)
Expand All @@ -248,7 +248,7 @@ def __init__(
warnings.warn(
(
"The argument 'event_timestamp_column' is being deprecated. Please use 'timestamp_field' instead. "
"instead. Feast 0.23 and onwards will not support the argument 'event_timestamp_column' for datasources."
"instead. Feast 0.24 and onwards will not support the argument 'event_timestamp_column' for datasources."
),
DeprecationWarning,
)
Expand Down Expand Up @@ -431,7 +431,7 @@ def __init__(
warnings.warn(
(
"Kafka parameters should be specified as a keyword argument instead of a positional arg."
"Feast 0.23+ will not support positional arguments to construct Kafka sources"
"Feast 0.24+ will not support positional arguments to construct Kafka sources"
),
DeprecationWarning,
)
Expand Down Expand Up @@ -592,7 +592,7 @@ def __init__(
warnings.warn(
(
"Request source parameters should be specified as a keyword argument instead of a positional arg."
"Feast 0.23+ will not support positional arguments to construct request sources"
"Feast 0.24+ will not support positional arguments to construct request sources"
),
DeprecationWarning,
)
Expand All @@ -611,7 +611,7 @@ def __init__(
raise ValueError("Schema needs to be provided for Request Source")
if isinstance(_schema, Dict):
warnings.warn(
"Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.23. "
"Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.24. "
"Please use List[Field] instead for the schema",
DeprecationWarning,
)
Expand Down Expand Up @@ -663,7 +663,7 @@ def from_proto(data_source: DataSourceProto):

if deprecated_schema and not schema_pb:
warnings.warn(
"Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.23. "
"Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.24. "
"Please use List[Field] instead for the schema",
DeprecationWarning,
)
Expand Down Expand Up @@ -724,7 +724,7 @@ def source_datatype_to_feast_value_type() -> Callable[[str], ValueType]:
class RequestDataSource(RequestSource):
def __init__(self, *args, **kwargs):
warnings.warn(
"The 'RequestDataSource' class is deprecated and was renamed to RequestSource. Please use RequestSource instead. This class name will be removed in Feast 0.23.",
"The 'RequestDataSource' class is deprecated and was renamed to RequestSource. Please use RequestSource instead. This class name will be removed in Feast 0.24.",
DeprecationWarning,
)
super().__init__(*args, **kwargs)
Expand Down Expand Up @@ -803,7 +803,7 @@ def __init__(
warnings.warn(
(
"Kinesis parameters should be specified as a keyword argument instead of a positional arg."
"Feast 0.23+ will not support positional arguments to construct kinesis sources"
"Feast 0.24+ will not support positional arguments to construct kinesis sources"
),
DeprecationWarning,
)
Expand Down Expand Up @@ -922,7 +922,7 @@ def __init__(
warnings.warn(
(
"Push source parameters should be specified as a keyword argument instead of a positional arg."
"Feast 0.23+ will not support positional arguments to construct push sources"
"Feast 0.24+ will not support positional arguments to construct push sources"
),
DeprecationWarning,
)
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/diff/registry_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def to_string(self):
if feast_object_diff.transition_type == TransitionType.UNCHANGED:
continue
if feast_object_diff.feast_object_type == FeastObjectType.DATA_SOURCE:
# TODO(adchia): Print statements out starting in Feast 0.23
# TODO(adchia): Print statements out starting in Feast 0.24
continue
action, color = message_action_map[feast_object_diff.transition_type]
log_string += f"{action} {feast_object_diff.feast_object_type.value} {Style.BRIGHT + color}{feast_object_diff.name}{Style.RESET_ALL}\n"
Expand Down
6 changes: 3 additions & 3 deletions sdk/python/feast/entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def __init__(
warnings.warn(
(
"Entity name should be specified as a keyword argument instead of a positional arg."
"Feast 0.23+ will not support positional arguments to construct Entities"
"Feast 0.24+ will not support positional arguments to construct Entities"
),
DeprecationWarning,
)
Expand All @@ -108,7 +108,7 @@ def __init__(
warnings.warn(
(
"The `value_type` parameter is being deprecated. Instead, the type of an entity "
"should be specified as a Field in the schema of a feature view. Feast 0.23 and "
"should be specified as a Field in the schema of a feature view. Feast 0.24 and "
"onwards will not support the `value_type` parameter. The `entities` parameter of "
"feature views should also be changed to a List[Entity] instead of a List[str]; if "
"this is not done, entity columns will be mistakenly interpreted as feature columns."
Expand All @@ -125,7 +125,7 @@ def __init__(
warnings.warn(
(
"The `join_key` parameter is being deprecated in favor of the `join_keys` parameter. "
"Please switch from using `join_key` to `join_keys`. Feast 0.23 and onwards will not "
"Please switch from using `join_key` to `join_keys`. Feast 0.24 and onwards will not "
"support the `join_key` parameter."
),
DeprecationWarning,
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/feature_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def __init__(
warnings.warn(
(
"Feature service parameters should be specified as a keyword argument instead of a positional arg."
"Feast 0.23+ will not support positional arguments to construct feature service"
"Feast 0.24+ will not support positional arguments to construct feature service"
),
DeprecationWarning,
)
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2504,7 +2504,7 @@ def _validate_data_sources(data_sources: List[DataSource]):
f"More than one data source with name {case_insensitive_ds_name} found. "
f"Please ensure that all data source names are case-insensitively unique. "
f"It may be necessary to ignore certain files in your feature repository by using a .feastignore "
f"file. Starting in Feast 0.23, unique names (perhaps inferred from the table name) will be "
f"file. Starting in Feast 0.24, unique names (perhaps inferred from the table name) will be "
f"required in data sources to encourage data source discovery"
)
else:
Expand Down
10 changes: 5 additions & 5 deletions sdk/python/feast/feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def __init__(
warnings.warn(
(
"feature view parameters should be specified as a keyword argument instead of a positional arg."
"Feast 0.23+ will not support positional arguments to construct feature views"
"Feast 0.24+ will not support positional arguments to construct feature views"
),
DeprecationWarning,
)
Expand Down Expand Up @@ -178,7 +178,7 @@ def __init__(
warnings.warn(
(
"The `entities` parameter should be a list of `Entity` objects. "
"Feast 0.23 and onwards will not support passing in a list of "
"Feast 0.24 and onwards will not support passing in a list of "
"strings to define entities."
),
DeprecationWarning,
Expand All @@ -191,7 +191,7 @@ def __init__(
warnings.warn(
(
"The option to pass a Duration object to the ttl parameter is being deprecated. "
"Please pass a timedelta object instead. Feast 0.23 and onwards will not support "
"Please pass a timedelta object instead. Feast 0.24 and onwards will not support "
"Duration objects."
),
DeprecationWarning,
Expand All @@ -206,7 +206,7 @@ def __init__(
(
"The `features` parameter is being deprecated in favor of the `schema` parameter. "
"Please switch from using `features` to `schema`. This will also requiring switching "
"feature definitions from using `Feature` to `Field`. Feast 0.23 and onwards will not "
"feature definitions from using `Feature` to `Field`. Feast 0.24 and onwards will not "
"support the `features` parameter."
),
DeprecationWarning,
Expand Down Expand Up @@ -282,7 +282,7 @@ def _initialize_sources(self, name, batch_source, stream_source, source):
else:
warnings.warn(
"batch_source and stream_source have been deprecated in favor of `source`."
"The deprecated fields will be removed in Feast 0.23.",
"The deprecated fields will be removed in Feast 0.24.",
DeprecationWarning,
)
if stream_source is not None and isinstance(stream_source, PushSource):
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/offline_stores/bigquery_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def __init__(
warnings.warn(
(
"The argument 'date_partition_column' is not supported for BigQuery sources. "
"It will be removed in Feast 0.23+"
"It will be removed in Feast 0.24+"
),
DeprecationWarning,
)
Expand All @@ -76,7 +76,7 @@ def __init__(
else:
warnings.warn(
(
f"Starting in Feast 0.23, Feast will require either a name for a data source (if using query) or `table`: {self.query}"
f"Starting in Feast 0.24, Feast will require either a name for a data source (if using query) or `table`: {self.query}"
),
DeprecationWarning,
)
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def __init__(
warnings.warn(
(
"The argument 'date_partition_column' is not supported for Spark sources."
"It will be removed in Feast 0.23+"
"It will be removed in Feast 0.24+"
),
DeprecationWarning,
)
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/offline_stores/file_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def __init__(
warnings.warn(
(
"File Source parameters should be specified as a keyword argument instead of a positional arg."
"Feast 0.23+ will not support positional arguments to construct File sources"
"Feast 0.24+ will not support positional arguments to construct File sources"
),
DeprecationWarning,
)
Expand All @@ -95,7 +95,7 @@ def __init__(
warnings.warn(
(
"The argument 'date_partition_column' is not supported for File sources."
"It will be removed in Feast 0.23+"
"It will be removed in Feast 0.24+"
),
DeprecationWarning,
)
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/offline_stores/redshift_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def __init__(
else:
warnings.warn(
(
f"Starting in Feast 0.23, Feast will require either a name for a data source (if using query) "
f"Starting in Feast 0.24, Feast will require either a name for a data source (if using query) "
f"or `table`: {self.query}"
),
DeprecationWarning,
Expand All @@ -82,7 +82,7 @@ def __init__(
warnings.warn(
(
"The argument 'date_partition_column' is not supported for Redshift sources."
"It will be removed in Feast 0.23+"
"It will be removed in Feast 0.24+"
),
DeprecationWarning,
)
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/offline_stores/snowflake_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def __init__(
else:
warnings.warn(
(
f"Starting in Feast 0.23, Feast will require either a name for a data source (if using query) "
f"Starting in Feast 0.24, Feast will require either a name for a data source (if using query) "
f"or `table`: {self.query}"
),
DeprecationWarning,
Expand All @@ -89,7 +89,7 @@ def __init__(
warnings.warn(
(
"The argument 'date_partition_column' is not supported for Snowflake sources."
"It will be removed in Feast 0.23+"
"It will be removed in Feast 0.24+"
),
DeprecationWarning,
)
Expand Down
Loading