Skip to content

fix: Enforce kw args in datasources #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 15 commits into from
Apr 19, 2022
Merged

fix: Enforce kw args in datasources #2567

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6c98880
Update
kevjumba Apr 18, 2022
092a1f0
Fix
kevjumba Apr 18, 2022
44af590
Update to keyword args
kevjumba Apr 18, 2022
50bd918
Fix lint
kevjumba Apr 18, 2022
8ddc48c
Fix
kevjumba Apr 18, 2022
d388599
Fix
kevjumba Apr 18, 2022
06cd1b6
Change kinesis to optional
kevjumba Apr 18, 2022
f9c374f
Fix review issues
kevjumba Apr 19, 2022
67eca66
Fix lint
kevjumba Apr 19, 2022
e292214
Add unit tests
kevjumba Apr 19, 2022
ad3ba3f
Fix
kevjumba Apr 19, 2022
a6007ef
Fix
kevjumba Apr 19, 2022
2a6797a
Fix imports
kevjumba Apr 19, 2022
8c487b4
Fix lint
kevjumba Apr 19, 2022
e023177
Fix
kevjumba Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Apr 19, 2022
commit 8c487b492c432e208810aa7568bd8e5786bf71c9
15 changes: 6 additions & 9 deletions sdk/python/tests/unit/test_data_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import pytest
from feast.data_format import ProtoFormat
from sdk.python.feast.data_format import ProtoFormat

from feast import ValueType
from feast.data_format import ProtoFormat
from feast.data_source import (
KafkaSource,
KinesisSource,
Expand All @@ -10,15 +11,9 @@
RequestSource,
)
from feast.field import Field
from feast.types import Bool, Float32, Int64
from feast.data_source import KafkaSource, KinesisSource, PushSource, RequestSource
from feast.infra.offline_stores.bigquery_source import BigQuerySource
from feast.infra.offline_stores.file_source import FileSource
from feast.infra.offline_stores.redshift_source import RedshiftSource
from feast.infra.offline_stores.snowflake_source import SnowflakeSource
from feast.infra.offline_stores.contrib.spark_offline_store.spark_source import SparkSource
from sdk.python.feast.data_format import ProtoFormat
from feast.types import Int64
from feast.types import Bool, Float32, Int64


def test_push_with_batch():
push_source = PushSource(
Expand Down Expand Up @@ -56,6 +51,7 @@ def test_request_source_primitive_type_to_proto():
deserialized_request_source = RequestSource.from_proto(request_proto)
assert deserialized_request_source == request_source


def test_hash():
push_source_1 = PushSource(
name="test", batch_source=BigQuerySource(table="test.test"),
Expand Down Expand Up @@ -84,6 +80,7 @@ def test_hash():
s4 = {push_source_1, push_source_2, push_source_3, push_source_4}
assert len(s4) == 3


# TODO(kevjumba): Remove this test in feast 0.23 when positional arguments are removed.
def test_default_data_source_kw_arg_warning():
# source_class = request.param
Expand Down