Skip to content

fix: Enforce kw args in datasources #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 15 commits into from
Apr 19, 2022
Merged

fix: Enforce kw args in datasources #2567

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6c98880
Update
kevjumba Apr 18, 2022
092a1f0
Fix
kevjumba Apr 18, 2022
44af590
Update to keyword args
kevjumba Apr 18, 2022
50bd918
Fix lint
kevjumba Apr 18, 2022
8ddc48c
Fix
kevjumba Apr 18, 2022
d388599
Fix
kevjumba Apr 18, 2022
06cd1b6
Change kinesis to optional
kevjumba Apr 18, 2022
f9c374f
Fix review issues
kevjumba Apr 19, 2022
67eca66
Fix lint
kevjumba Apr 19, 2022
e292214
Add unit tests
kevjumba Apr 19, 2022
ad3ba3f
Fix
kevjumba Apr 19, 2022
a6007ef
Fix
kevjumba Apr 19, 2022
2a6797a
Fix imports
kevjumba Apr 19, 2022
8c487b4
Fix lint
kevjumba Apr 19, 2022
e023177
Fix
kevjumba Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Apr 19, 2022
commit 6c988800a511417be5c6b787c4bd39281dbacf42
36 changes: 21 additions & 15 deletions sdk/python/feast/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ class DataSource(ABC):

def __init__(
self,
*,
Comment thread
kevjumba marked this conversation as resolved.
Outdated
event_timestamp_column: Optional[str] = None,
created_timestamp_column: Optional[str] = None,
field_mapping: Optional[Dict[str, str]] = None,
Expand Down Expand Up @@ -354,11 +355,12 @@ def get_table_column_names_and_types(

def __init__(
self,
name: str,
event_timestamp_column: str,
bootstrap_servers: str,
message_format: StreamFormat,
topic: str,
*,
name: Optional[str] = None,
event_timestamp_column: Optional[str] = "",
Comment thread
adchia marked this conversation as resolved.
Outdated
bootstrap_servers: Optional[str] = "",
message_format: Optional[StreamFormat] = None,
topic: Optional[str] = "",
created_timestamp_column: Optional[str] = "",
field_mapping: Optional[Dict[str, str]] = None,
date_partition_column: Optional[str] = "",
Expand Down Expand Up @@ -472,14 +474,17 @@ class RequestSource(DataSource):

def __init__(
self,
name: str,
schema: Union[Dict[str, ValueType], List[Field]],
*,
name: Optional[str] = None,
schema: Optional[Union[Dict[str, ValueType], List[Field]]] = None,
description: Optional[str] = "",
tags: Optional[Dict[str, str]] = None,
owner: Optional[str] = "",
):
"""Creates a RequestSource object."""
super().__init__(name=name, description=description, tags=tags, owner=owner)
if not schema:
raise ValueError("Schema needs to be provided for Request Source")
if isinstance(schema, Dict):
warnings.warn(
"Schema in RequestSource is changing type. The schema data type Dict[str, ValueType] is being deprecated in Feast 0.23. "
Expand Down Expand Up @@ -643,12 +648,13 @@ def get_table_query_string(self) -> str:

def __init__(
self,
name: str,
event_timestamp_column: str,
created_timestamp_column: str,
record_format: StreamFormat,
region: str,
stream_name: str,
*,
name: Optional[str] = None,
event_timestamp_column: Optional[str] = "",
created_timestamp_column: Optional[str] = "",
record_format: Optional[StreamFormat] = None,
region: Optional[str] = "",
stream_name: Optional[str] = "",
field_mapping: Optional[Dict[str, str]] = None,
date_partition_column: Optional[str] = "",
description: Optional[str] = "",
Expand Down Expand Up @@ -726,8 +732,8 @@ class PushSource(DataSource):
def __init__(
self,
*,
name: str,
batch_source: DataSource,
name: Optional[str] = None,
batch_source: Optional[DataSource] = None,
description: Optional[str] = "",
tags: Optional[Dict[str, str]] = None,
owner: Optional[str] = "",
Expand Down
1 change: 1 addition & 0 deletions sdk/python/feast/infra/offline_stores/bigquery_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
class BigQuerySource(DataSource):
def __init__(
self,
*,
event_timestamp_column: Optional[str] = "",
table: Optional[str] = None,
created_timestamp_column: Optional[str] = "",
Expand Down
1 change: 1 addition & 0 deletions sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ class SparkSourceFormat(Enum):
class SparkSource(DataSource):
def __init__(
self,
*,
name: Optional[str] = None,
table: Optional[str] = None,
query: Optional[str] = None,
Expand Down
1 change: 0 additions & 1 deletion sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ def __init__(
table: Optional[str] = None,
created_timestamp_column: Optional[str] = "",
field_mapping: Optional[Dict[str, str]] = None,
date_partition_column: Optional[str] = None,
Comment thread
adchia marked this conversation as resolved.
Outdated
query: Optional[str] = None,
name: Optional[str] = None,
description: Optional[str] = "",
Expand Down
1 change: 1 addition & 0 deletions sdk/python/feast/infra/offline_stores/file_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
class FileSource(DataSource):
def __init__(
self,
*,
Copy link
Copy Markdown
Collaborator

@adchia adchia Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not need warnings in the other sources too?

Copy link
Copy Markdown
Collaborator Author

@kevjumba kevjumba Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other sources already have optional args(if they don't have positional args I didn't touch them.

path: str,
event_timestamp_column: Optional[str] = "",
file_format: Optional[FileFormat] = None,
Expand Down
1 change: 1 addition & 0 deletions sdk/python/feast/infra/offline_stores/redshift_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
class RedshiftSource(DataSource):
def __init__(
self,
*,
event_timestamp_column: Optional[str] = "",
table: Optional[str] = None,
schema: Optional[str] = None,
Expand Down
1 change: 1 addition & 0 deletions sdk/python/feast/infra/offline_stores/snowflake_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
class SnowflakeSource(DataSource):
def __init__(
self,
*,
database: Optional[str] = None,
warehouse: Optional[str] = None,
schema: Optional[str] = None,
Expand Down