Skip to content

fix: Enforce kw args in datasources #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 15 commits into from
Apr 19, 2022
Merged

fix: Enforce kw args in datasources #2567

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6c98880
Update
kevjumba Apr 18, 2022
092a1f0
Fix
kevjumba Apr 18, 2022
44af590
Update to keyword args
kevjumba Apr 18, 2022
50bd918
Fix lint
kevjumba Apr 18, 2022
8ddc48c
Fix
kevjumba Apr 18, 2022
d388599
Fix
kevjumba Apr 18, 2022
06cd1b6
Change kinesis to optional
kevjumba Apr 18, 2022
f9c374f
Fix review issues
kevjumba Apr 19, 2022
67eca66
Fix lint
kevjumba Apr 19, 2022
e292214
Add unit tests
kevjumba Apr 19, 2022
ad3ba3f
Fix
kevjumba Apr 19, 2022
a6007ef
Fix
kevjumba Apr 19, 2022
2a6797a
Fix imports
kevjumba Apr 19, 2022
8c487b4
Fix lint
kevjumba Apr 19, 2022
e023177
Fix
kevjumba Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change kinesis to optional 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Apr 19, 2022
commit 06cd1b69c7870b002c5b8a34a7f851d158442490
12 changes: 6 additions & 6 deletions sdk/python/feast/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,12 +710,12 @@ def get_table_query_string(self) -> str:
def __init__(
self,
*args,
name: str,
event_timestamp_column: str,
created_timestamp_column: str,
record_format: StreamFormat,
region: str,
stream_name: str,
name: Optional[str] = None,
event_timestamp_column: Optional[str] = "",
created_timestamp_column: Optional[str] = "",
record_format: Optional[StreamFormat] = None,
region: Optional[str] = "",
stream_name: Optional[str] = "",
field_mapping: Optional[Dict[str, str]] = None,
date_partition_column: Optional[str] = "",
description: Optional[str] = "",
Expand Down