Fix dry_run bug that was making to_bigquery hang indefinitely#1706
Fix dry_run bug that was making to_bigquery hang indefinitely#1706feast-ci-bot merged 1 commit intofeast-dev:masterfrom
Conversation
Signed-off-by: Cody Lin <codyl@twitter.com>
|
Hi @codyjlin. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind bug |
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
=======================================
Coverage 82.75% 82.75%
=======================================
Files 76 76
Lines 6754 6754
=======================================
Hits 5589 5589
Misses 1165 1165
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, codyjlin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…dev#1706) Signed-off-by: Cody Lin <codyl@twitter.com> Signed-off-by: CS <2498638+charliec443@users.noreply.github.com>
Signed-off-by: Cody Lin codyl@twitter.com
What this PR does / why we need it:
In PR #1661, I accidentally switched the order of the
dry_runoutput and_block_until_done(these lines) inBigQueryRetrievalJob.to_bigquerythat was making anydry_runcall to hang. I fix it here.Which issue(s) this PR fixes:
(Not large enough for issue)
Does this PR introduce a user-facing change?: