Skip to content

Fix dry_run bug that was making to_bigquery hang indefinitely #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Jul 12, 2021
Merged

Fix dry_run bug that was making to_bigquery hang indefinitely #1706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions sdk/python/feast/infra/offline_stores/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,17 +268,17 @@ def to_bigquery(self, job_config: bigquery.QueryJobConfig = None) -> Optional[st

bq_job = self.client.query(self.query, job_config=job_config)

block_until_done(client=self.client, bq_job=bq_job)

if bq_job.exception():
raise bq_job.exception()

if job_config.dry_run:
print(
"This query will process {} bytes.".format(bq_job.total_bytes_processed)
)
return None

block_until_done(client=self.client, bq_job=bq_job)

if bq_job.exception():
raise bq_job.exception()

print(f"Done writing to '{job_config.destination}'.")
return str(job_config.destination)

Expand Down