Fix dry_run bug that was making to_bigquery hang indefinitely (#1706)

codyjlin · web-flow · commit 0d0492d734ea · 2021-07-12T14:05:58.000-07:00
Signed-off-by: Cody Lin &lt;codyl@twitter.com&gt;
diff --git a/sdk/python/feast/infra/offline_stores/bigquery.py b/sdk/python/feast/infra/offline_stores/bigquery.py
@@ -268,17 +268,17 @@ def to_bigquery(self, job_config: bigquery.QueryJobConfig = None) -> Optional[st
 
         bq_job = self.client.query(self.query, job_config=job_config)
 
-        block_until_done(client=self.client, bq_job=bq_job)
-
-        if bq_job.exception():
-            raise bq_job.exception()
-
         if job_config.dry_run:
             print(
                 "This query will process {} bytes.".format(bq_job.total_bytes_processed)
             )
             return None
 
+        block_until_done(client=self.client, bq_job=bq_job)
+
+        if bq_job.exception():
+            raise bq_job.exception()
+
         print(f"Done writing to '{job_config.destination}'.")
         return str(job_config.destination)
 
