Validate project and repo names for apply and init commands - #1558

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedhtchang, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@77a7975). Learn more about missing BASE report.

@@            Coverage Diff            @@
##             master    #1558   +/-   ##
=========================================
  Coverage          ?   83.42%           
=========================================
  Files             ?       65           
  Lines             ?     5653           
  Branches          ?        0           
=========================================
  Hits              ?     4716           
  Misses            ?      937           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tedhtchang @woop
Would it make sense to make it airtight by ensuring that no names start with "_<table_name>" as SQLite, I believe, disallows _sqlite_table_name or _table_name. WDYT?

(And a minor nit: Python style suggests that boolean functions
conventionally are isdigit() isalpha(), islower() etc. Should this be renamed as is_valid_name() ? ) Up to you guys. :-)

def not_valid_name(name: str) -> bool:    
"""Test project or repo names. True if names have characters other than alphanumeric values and underscores"""    return 
     return name.startswith("_") or re.compile(r"\W+").search(name) is not None

@tedhtchang @woop
Would it make sense to make it airtight by ensuring that no names start with "_<table_name>" as SQLite, I believe, disallows _sqlite_table_name or _table_name. WDYT?

(And a minor nit: Python style suggests that boolean functions
conventionally are isdigit() isalpha(), islower() etc. Should this be renamed as is_valid_name() ? ) Up to you guys. :-)

def not_valid_name(name: str) -> bool:    
"""Test project or repo names. True if names have characters other than alphanumeric values and underscores"""    return 
     return name.startswith("_") or re.compile(r"\W+").search(name) is not None

Yea, both suggestions make sense to me

@woop @dmatrix i will work on it.