validate project and repo names for apply and init commands (#1558)

tedhtchang · woop · commit 883f52b3d2f0 · 2021-05-19T12:28:34.000-07:00
Signed-off-by: ted chang &lt;htchang@us.ibm.com&gt;
diff --git a/sdk/python/feast/repo_operations.py b/sdk/python/feast/repo_operations.py
@@ -1,13 +1,15 @@
 import importlib
 import os
 import random
+import re
 import sys
 from datetime import timedelta
 from importlib.abc import Loader
 from pathlib import Path
 from typing import List, NamedTuple, Set, Union
 
 import click
+from click.exceptions import BadParameter
 
 from feast import Entity, FeatureTable
 from feast.feature_view import FeatureView
@@ -112,6 +114,12 @@ def apply_total(repo_config: RepoConfig, repo_path: Path):
     sys.path.append("")
     registry_config = repo_config.get_registry_config()
     project = repo_config.project
+    if not_valid_name(project):
+        print(
+            f"{project} is not valid. Project name should only have "
+            f"alphanumerical values and underscores."
+        )
+        sys.exit(1)
     registry = Registry(
         registry_path=registry_config.path,
         repo_path=repo_path,
@@ -267,6 +275,11 @@ def init_repo(repo_name: str, template: str):
 
     from colorama import Fore, Style
 
+    if not_valid_name(repo_name):
+        raise BadParameter(
+            message="Name should be alphanumeric values and underscores",
+            param_hint="PROJECT_DIRECTORY",
+        )
     repo_path = Path(os.path.join(Path.cwd(), repo_name))
     repo_path.mkdir(exist_ok=True)
     repo_config_path = repo_path / "feature_store.yaml"
@@ -319,6 +332,11 @@ def init_repo(repo_name: str, template: str):
     click.echo()
 
 
+def not_valid_name(name: str) -> bool:
+    """Test project or repo names. True if names have characters other than alphanumeric values and underscores"""
+    return re.compile(r"\W+").search(name) is not None
+
+
 def replace_str_in_file(file_path, match_str, sub_str):
     with open(file_path, "r") as f:
         contents = f.read()
