Implement materialize method - #1379
Merged
Merged
Conversation
Collaborator
Author
|
Note this is stacked on #1366 |
jklegar
force-pushed
the
jacob_ingest_firestore
branch
from
March 15, 2021 23:50
e8aa700 to
0b6f95b
Compare
jklegar
force-pushed
the
jacob_ingest_firestore
branch
from
March 16, 2021 17:30
0b6f95b to
59303c5
Compare
jklegar
force-pushed
the
jacob_ingest_firestore
branch
from
March 16, 2021 23:43
3a2ddf6 to
1abd497
Compare
Collaborator
Author
|
/test test-telemetry |
woop
reviewed
Mar 17, 2021
woop
reviewed
Mar 17, 2021
woop
reviewed
Mar 17, 2021
woop
reviewed
Mar 17, 2021
woop
reviewed
Mar 17, 2021
woop
reviewed
Mar 17, 2021
woop
reviewed
Mar 17, 2021
oavdeev
reviewed
Mar 17, 2021
woop
reviewed
Mar 17, 2021
woop
reviewed
Mar 17, 2021
woop
reviewed
Mar 17, 2021
woop
reviewed
Mar 17, 2021
woop
reviewed
Mar 17, 2021
woop
reviewed
Mar 17, 2021
Member
There was a problem hiding this comment.
It's not clear to me how or why timestamp_mapped occurs twice. Is that supposed to work?
woop
reviewed
Mar 19, 2021
woop
reviewed
Mar 21, 2021
woop
reviewed
Mar 21, 2021
woop
reviewed
Mar 21, 2021
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
jklegar
force-pushed
the
jacob_ingest_firestore
branch
from
March 22, 2021 15:31
ebf132b to
5d06340
Compare
woop
reviewed
Mar 22, 2021
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Collaborator
Author
|
/kind feature |
woop
approved these changes
Mar 22, 2021
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Implements ingestion into Firestore, which will be part of the python-based ingestion flow
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: