Skip to content

Commit 5d06340

Browse files
committed
Address comments
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
1 parent c8ddd76 commit 5d06340

2 files changed

Lines changed: 17 additions & 9 deletions

File tree

sdk/python/feast/feature_store.py

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# limitations under the License.
1414
from datetime import datetime
1515
from pathlib import Path
16-
from typing import Dict, List, Optional, Tuple, Type, Union
16+
from typing import Dict, List, Optional, Tuple, Union
1717

1818
import pandas as pd
1919
import pyarrow
@@ -23,7 +23,6 @@
2323
from feast.feature_view import FeatureView
2424
from feast.infra.provider import Provider, get_provider
2525
from feast.offline_store import (
26-
OfflineStore,
2726
RetrievalJob,
2827
get_offline_store,
2928
get_offline_store_for_retrieval,
@@ -69,9 +68,6 @@ def __init__(
6968
def _get_provider(self) -> Provider:
7069
return get_provider(self.config)
7170

72-
def _get_offline_store(self) -> Type[OfflineStore]:
73-
return get_offline_store(self.config)
74-
7571
def _get_registry(self) -> Registry:
7672
return Registry(self.config.metadata_store)
7773

@@ -183,8 +179,20 @@ def materialize(
183179
Args:
184180
feature_views (List[str]): Optional list of feature view names. If selected, will only run
185181
materialization for the specified feature views.
186-
start_date (datetime): Start date of query
187-
end_date (datetime): End date of query
182+
start_date (datetime): Start date for time range of data to materialize into the online store
183+
end_date (datetime): End date for time range of data to materialize into the online store
184+
185+
Examples:
186+
Materialize all features into the online store over the interval
187+
from 3 hours ago to 10 minutes ago.
188+
>>> from datetime import datetime, timedelta
189+
>>> from feast.feature_store import FeatureStore
190+
>>>
191+
>>> fs = FeatureStore(config=RepoConfig(provider="gcp"))
192+
>>> fs.materialize(
193+
>>> start_date=datetime.utcnow() - timedelta(hours=3),
194+
>>> end_date=datetime.utcnow() - timedelta(minutes=10)
195+
>>> )
188196
"""
189197
feature_views_to_materialize = []
190198
registry = self._get_registry()
@@ -214,7 +222,7 @@ def materialize(
214222
created_timestamp_column,
215223
) = _run_reverse_field_mapping(feature_view)
216224

217-
offline_store = self._get_offline_store()
225+
offline_store = get_offline_store(self.config)
218226
table = offline_store.pull_latest_from_table(
219227
feature_view.input,
220228
entity_names,

sdk/python/tests/test_bigquery_ingestion.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818

1919
@pytest.mark.integration
20-
class TestBigQueryIngestion:
20+
class TestMaterializeFromBigQueryToDatastore:
2121
def setup_method(self):
2222
self.client = bigquery.Client()
2323
self.gcp_project = self.client.project

0 commit comments

Comments
 (0)