Skip to content

Support pulling query from BigQuery - #1403

Merged
feast-ci-bot merged 5 commits into
feast-dev:masterfrom
jklegar:jacob_pull_query
Mar 24, 2021
Merged

Support pulling query from BigQuery#1403
feast-ci-bot merged 5 commits into
feast-dev:masterfrom
jklegar:jacob_pull_query

Conversation

@jklegar

@jklegar jklegar commented Mar 22, 2021

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it: Add support to materialize a specified BigQuery query into the online store

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Adds support to materialize a specified BigQuery query into the online store

@jklegar

jklegar commented Mar 22, 2021

Copy link
Copy Markdown
Collaborator Author

Note this is stacked on #1379

@jklegar

jklegar commented Mar 22, 2021

Copy link
Copy Markdown
Collaborator Author

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Mar 22, 2021
@woop

woop commented Mar 23, 2021

Copy link
Copy Markdown
Member

@jklegar can you please rename test_bigquery_ingestion.py to test_materialize_from_bigquery_into_datastore.py or something?

Comment thread sdk/python/tests/test_bigquery_ingestion.py Outdated
jklegar added 2 commits March 23, 2021 18:12
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Comment thread sdk/python/tests/test_materialize_from_bigquery_to_datastore.py
Comment thread sdk/python/tests/test_materialize_from_bigquery_to_datastore.py
jklegar added 2 commits March 24, 2021 13:08
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@woop

woop commented Mar 24, 2021

Copy link
Copy Markdown
Member

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit f1e3072 into feast-dev:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants