Repository navigation
ci: align actions/checkout on the v4.3.1 standard pin - #170
Conversation
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 72 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
The following comment was made by an LLM, it may be inaccurate: |
Problem
#160's remainder: after PR #161 retired checkout v3.6.0 and PR #165 made github-script uniform at v8.0.0,
actions/checkoutwas still pinned at two majors on main1ed7398e10:34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1— 38 sitesde0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2— 2 sites:nix-eval.yml:29andnix-hashes.yml:51(the latter mixing two majors in one file, since its second checkout at :107 is already v4.3.1)Solution / standard chosen
Standard: v4.3.1 (
34e114876b0b11c390a56381ad16ebd13914f8d5), the pin PR #161 already established as the repo standard when it moved the 16 deploy/publish v3.6.0 sites onto it. Aligning the 2 outliers down is a 2-line change; moving all 38 sites up to v6.0.2 would be a much larger, separately-motivated bump.Both v6.0.2 sites are bare checkouts with no
with:block, so no v6-only input is in use; the v4.3.1 checkout in the samenix-hashes.ymlfile already usespersist-credentials/fetch-depth/ref, all supported by v4.3.1.This PR changes exactly those 2 lines (nix-eval.yml, nix-hashes.yml compute-hash job). No
with:inputs touched.Verification
actions/checkoutuses are the single v4.3.1 SHA pin; zero v6.0.2 (and zero v3.6.0) remain.actions/github-scriptalready uniform: 4/4 at v8.0.0 (PR ci: pin actions/github-script at v8.0.0 everywhere (#164) #165) — untouched.nix-evalitself (pull_request to main), which runs its checkout step under the newly aligned pin.Closes #160
Origin issue: #160 — single-repo (sibling repos checked in the issue: nix uniform v7.0.1, openchamber uniform, code floats tags), so no downstream port is owed.
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit