Skip to content

ci: actions/checkout is pinned at three different majors (v3.6.0 / v4.3.1 / v6.0.2) — nix-hashes.yml mixes two in one file #160

Closed

Description

@dezren39

Problem

This repo SHA-pins its GitHub Actions with version comments, but actions/checkout is pinned at three different major versions across the workflows, and actions/github-script at two:

Verified on main 6388e35b3f by enumerating every uses: line in .github/workflows/:

Action Pins in use Count
actions/checkout f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0 16
actions/checkout 34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1 22
actions/checkout de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 2 (+1 more below)
actions/github-script f28e40c7f34bde8b3046d885e986cb6290c5673b # v7.1.0 3
actions/github-script ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0 1

The v3.6.0 checkouts are the deploy and publish family: deploy.yml, deploy-changelog.yml, deploy-files.yml, deploy-posts.yml, deploy-update.yml, deploy-www.yml (1 each), publish-github-action.yml, publish-vscode.yml (1 each) and publish.yml (8).

Sharpest instance: .github/workflows/nix-hashes.yml mixes two majors in one file — line 51 checks out with v6.0.2 and line 107 with v4.3.1.

Why it matters

Acceptance criteria

  • Every actions/checkout use in .github/workflows/ resolves to ONE SHA pin with an accurate version comment. Recommended direction: retire v3.6.0 first by moving the deploy/publish family onto the repo-standard v4.3.1 pin (34e114876b0b11c390a56381ad16ebd13914f8d5); then decide whether the standard becomes v4.3.1 or v6.0.2 and align the remainder (including both sites in nix-hashes.yml) in the same pass.
  • actions/github-script likewise aligned to one pin (v7.1.0 ×3 vs v8.0.0 ×1 in pr-management.yml:93).
  • All edited workflows still parse as YAML, and at least one PR-triggered workflow that uses the new standard pin runs green in CI.
  • A note in the PR body recording which pin was chosen as the standard and why, so the next bump has a single place to start from.

Scope / cross-repo check

Single-repo. The same enumeration in the sibling repos does not show this pattern: dezren39/nix is uniform (checkout v7.0.1 everywhere), developing-today/openchamber is uniform v7.0.1 apart from a jules-workflow straggler already covered by its PR #144, and developing-today/code uses floating major tags (a different, separately tracked convention).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions