Skip to content

fix(site): fix provider link on models page pointing to stale path#26011

Merged
tracyjohnsonux merged 3 commits into
mainfrom
tracy/codagt-547-remove-stale-provider-view-and-duplicate-provider-links
Jun 3, 2026
Merged

fix(site): fix provider link on models page pointing to stale path#26011
tracyjohnsonux merged 3 commits into
mainfrom
tracy/codagt-547-remove-stale-provider-view-and-duplicate-provider-links

Conversation

@tracyjohnsonux
Copy link
Copy Markdown
Contributor

@tracyjohnsonux tracyjohnsonux commented Jun 3, 2026

Fixes https://linear.app/codercom/issue/CODAGT-547

The "Connect a provider" link shown on /agents/settings/models when no providers are configured was pointing to /agents/settings/providers (a stale duplicate view) instead of /ai/settings (the canonical provider configuration page).

Audited all frontend source files for references to the stale path. This was the only link; other references to /ai/settings already point to the correct page.

Generated by Coder Agents This PR was generated by Coder Agents on behalf of @tracyjohnsonux.

@tracyjohnsonux tracyjohnsonux force-pushed the tracy/codagt-547-remove-stale-provider-view-and-duplicate-provider-links branch from 2d6cd3a to e4fe12e Compare June 3, 2026 03:43
@tracyjohnsonux Coder
Copy link
Copy Markdown
Contributor Author

tracyjohnsonux commented Jun 3, 2026

/coder-agents-review

@coder-agents-review
Copy link
Copy Markdown
Contributor

coder-agents-review Bot commented Jun 3, 2026 •
edited
Loading

Chat: Review posted | View chat
Requested: 2026-06-03 03:44 UTC by @tracyjohnsonux
Spend: $1.89 / $100.00

Review history
  • R1 (2026-06-03), 1 P2, COMMENT. Review

deep-review v0.6.1 | Round 1 | b493445..e4fe12e

Last posted: Round 1, 1 findings (1 P2), COMMENT. Review

Finding inventory

Finding inventory

Findings

# Sev Status Location Summary Round Reviewer Posted
CRF-1 P2 Open AgentSettingsProvidersPage.tsx:1 Dead file: 101-line page component has zero importers after this PR removes its only lazy import R1 Netero Yes

Round log

Round 1

Netero-only. 1 P2. Reviewed against b493445..e4fe12e.

About deep-review

CRF = Coder Review Finding (P0-P4, Nit, Note)

Reviewer Focus
Bisky tests
Chopper ops/errors
Churn-guard change verification
Ging language modernization
Gon naming
Hisoka edge cases
Killua perf
Kite change integrity
Knov contracts
Knuckle SQL
Kurapika security
Law decomposition
Leorio docs
Luffy product
Mafu-san process
Mafuuu contracts
Melody dispatch/pairing
Meruem structural
Nami frontend
Netero mechanical checks
Pariston premise testing
Pen-botter product gaps
Razor verification
Robin duplication
Ryosuke Go arch
Takumi concurrency
Zoro shape

🤖 Managed by Coder Agents.

coder-agents-review[bot]
coder-agents-review Bot reviewed Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coder-agents-review coder-agents-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix redirecting the stale /agents/settings/providers link to /ai/settings. The route redirect via <Navigate> preserves backward compat for bookmarked URLs. Test updated to match. One P2 below.

This is a first-pass (Netero) review only. These are mechanical findings the author should address before the full review panel spends time. The panel will review after these are resolved.

"Only self-references remain. The file should be deleted." - Netero, finding dead weight

🤖 This review was automatically generated with Coder Agents.

Comment thread site/src/router.tsx Outdated
@tracyjohnsonux tracyjohnsonux force-pushed the tracy/codagt-547-remove-stale-provider-view-and-duplicate-provider-links branch from e4fe12e to ee04b4b Compare June 3, 2026 03:55
@tracyjohnsonux
fix(site): fix provider link on models page pointing to stale path
900df16 
The "Connect a provider" link on /agents/settings/models was pointing
to /agents/settings/providers instead of /ai/settings. Update the link
to point to the canonical provider configuration page.
@tracyjohnsonux tracyjohnsonux force-pushed the tracy/codagt-547-remove-stale-provider-view-and-duplicate-provider-links branch from ee04b4b to 900df16 Compare June 3, 2026 03:59
@tracyjohnsonux tracyjohnsonux marked this pull request as ready for review June 3, 2026 04:11
@tracyjohnsonux tracyjohnsonux requested a review from jaaydenh June 3, 2026 04:12
@tracyjohnsonux
Copy link
Copy Markdown
Contributor Author

tracyjohnsonux commented Jun 3, 2026

@jaaydenh The agent wants a file deleted, but I'm typically pretty gunshy about doing that as its been drilled in me there is a process for correct EOL.

@jaaydenh
Copy link
Copy Markdown
Contributor

jaaydenh commented Jun 3, 2026

@tracyjohnsonux Since Fraley asked for the old providers page to be removed and the Agents didn't find any problems with doing this, I think it should be fine to delete.

@tracyjohnsonux tracyjohnsonux merged commit 8a9580a into main Jun 3, 2026
29 checks passed
@tracyjohnsonux tracyjohnsonux deleted the tracy/codagt-547-remove-stale-provider-view-and-duplicate-provider-links branch June 3, 2026 06:19
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jaaydenh jaaydenh jaaydenh approved these changes

+1 more reviewer

@coder-agents-review coder-agents-review[bot] coder-agents-review[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tracyjohnsonux tracyjohnsonux

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tracyjohnsonux @jaaydenh