Skip to content

fix(site): fix provider link on models page pointing to stale path #26011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tracyjohnsonux merged 3 commits into from
Jun 3, 2026
+6 −115
Merged

fix(site): fix provider link on models page pointing to stale path #26011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
900df16
fix(site): fix provider link on models page pointing to stale path
tracyjohnsonux Jun 3, 2026
8570b58
fix: remove providers from ADMIN_SETTINGS_SECTIONS
jaaydenh Jun 3, 2026
bbc453c
fix: remove test
jaaydenh Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 0 additions & 101 deletions site/src/pages/AgentsPage/AgentSettingsProvidersPage.tsx
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export const LinksToProvidersFromEmptyState: Story = {

await expect(canvas.getByText("No models configured yet.")).toBeVisible();
await expect(providerLink).toBeVisible();
expect(providerLink).toHaveAttribute("href", "/agents/settings/providers");
expect(providerLink).toHaveAttribute("href", "/ai/settings");
},
};

Expand Down
2 changes: 1 addition & 1 deletion site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ export const ModelsSection: FC<ModelsSectionProps> = ({
<p className="m-0 text-xs text-content-secondary">
Connect a{" "}
<Link
to="/agents/settings/providers"
to="/ai/settings"
className="underline transition-colors hover:text-content-primary"
>
provider
Expand Down
7 changes: 0 additions & 7 deletions site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,6 @@ describe("sidebarViewFromPath", () => {
});
});

it("returns the providers admin settings section", () => {
expect(sidebarViewFromPath("/agents/settings/providers")).toEqual({
panel: "settings-admin",
section: "providers",
});
});

it("normalizes the admin index route to an undefined section", () => {
expect(sidebarViewFromPath("/agents/settings/admin")).toEqual({
panel: "settings-admin",
Expand Down
1 change: 0 additions & 1 deletion site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ type SidebarView =
const ADMIN_SETTINGS_SECTIONS = new Set([
"agents",
"templates",
"providers",
"models",
"mcp-servers",
"spend",
Expand Down
8 changes: 4 additions & 4 deletions site/src/router.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,9 +384,6 @@ const AgentSettingsUserAgentsPage = lazy(
const AgentSettingsPersonalSkillsPage = lazy(
() => import("./pages/AgentsPage/AgentSettingsPersonalSkillsPage"),
);
const AgentSettingsProvidersPage = lazy(
() => import("./pages/AgentsPage/AgentSettingsProvidersPage"),
);
const AgentSettingsAPIKeysPage = lazy(
() => import("./pages/AgentsPage/AgentSettingsAPIKeysPage"),
);
Expand Down Expand Up @@ -791,7 +788,10 @@ export const router = createBrowserRouter(
<Route path="admin" element={<AgentSettingsAgentsPage />} />
<Route path="agents" element={<AgentSettingsAgentsPage />} />
<Route path="api-keys" element={<AgentSettingsAPIKeysPage />} />
<Route path="providers" element={<AgentSettingsProvidersPage />} />
<Route
path="providers"
element={<Navigate to="/ai/settings" replace />}
/>
<Route path="models" element={<AgentSettingsModelsPage />} />
<Route
path="mcp-servers"
Expand Down
Loading