fix(site): fix provider link on models page pointing to stale path (#26011)

tracyjohnsonux · jaaydenh · web-flow · commit 8a9580a29452 · 2026-06-02T23:19:33.000-07:00
Fixes https://linear.app/codercom/issue/CODAGT-547 The "Connect a provider" link shown on `/agents/settings/models` when no providers are configured was pointing to `/agents/settings/providers` (a stale duplicate view) instead of `/ai/settings` (the canonical provider configuration page). Audited all frontend source files for references to the stale path. This was the only link; other references to `/ai/settings` already point to the correct page. <details><summary>Generated by Coder Agents</summary> This PR was generated by Coder Agents on behalf of @tracyjohnsonux. </details> --------- Co-authored-by: Jaayden Halko <jaayden@coder.com>
diff --git a/site/src/pages/AgentsPage/AgentSettingsProvidersPage.tsx b/site/src/pages/AgentsPage/AgentSettingsProvidersPage.tsx
diff --git a/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.stories.tsx b/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.stories.tsx
@@ -164,7 +164,7 @@ export const LinksToProvidersFromEmptyState: Story = {
 
 		await expect(canvas.getByText("No models configured yet.")).toBeVisible();
 		await expect(providerLink).toBeVisible();
-		expect(providerLink).toHaveAttribute("href", "/agents/settings/providers");
+		expect(providerLink).toHaveAttribute("href", "/ai/settings");
 	},
 };
 
diff --git a/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.tsx b/site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelsSection.tsx
@@ -311,7 +311,7 @@ export const ModelsSection: FC<ModelsSectionProps> = ({
 						<p className="m-0 text-xs text-content-secondary">
 							Connect a{" "}
 							<Link
-								to="/agents/settings/providers"
+								to="/ai/settings"
 								className="underline transition-colors hover:text-content-primary"
 							>
 								provider
diff --git a/site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.test.ts b/site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.test.ts
@@ -53,13 +53,6 @@ describe("sidebarViewFromPath", () => {
 		});
 	});
 
-	it("returns the providers admin settings section", () => {
-		expect(sidebarViewFromPath("/agents/settings/providers")).toEqual({
-			panel: "settings-admin",
-			section: "providers",
-		});
-	});
-
 	it("normalizes the admin index route to an undefined section", () => {
 		expect(sidebarViewFromPath("/agents/settings/admin")).toEqual({
 			panel: "settings-admin",
diff --git a/site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.ts b/site/src/pages/AgentsPage/components/ChatsSidebar/sidebarView.ts
@@ -7,7 +7,6 @@ type SidebarView =
 const ADMIN_SETTINGS_SECTIONS = new Set([
 	"agents",
 	"templates",
-	"providers",
 	"models",
 	"mcp-servers",
 	"spend",
diff --git a/site/src/router.tsx b/site/src/router.tsx
@@ -384,9 +384,6 @@ const AgentSettingsUserAgentsPage = lazy(
 const AgentSettingsPersonalSkillsPage = lazy(
 	() => import("./pages/AgentsPage/AgentSettingsPersonalSkillsPage"),
 );
-const AgentSettingsProvidersPage = lazy(
-	() => import("./pages/AgentsPage/AgentSettingsProvidersPage"),
-);
 const AgentSettingsAPIKeysPage = lazy(
 	() => import("./pages/AgentsPage/AgentSettingsAPIKeysPage"),
 );
@@ -791,7 +788,10 @@ export const router = createBrowserRouter(
 						<Route path="admin" element={<AgentSettingsAgentsPage />} />
 						<Route path="agents" element={<AgentSettingsAgentsPage />} />
 						<Route path="api-keys" element={<AgentSettingsAPIKeysPage />} />
-						<Route path="providers" element={<AgentSettingsProvidersPage />} />
+						<Route
+							path="providers"
+							element={<Navigate to="/ai/settings" replace />}
+						/>
 						<Route path="models" element={<AgentSettingsModelsPage />} />
 						<Route
 							path="mcp-servers"

Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,7 @@ export const ModelsSection: FC<ModelsSectionProps> = ({`
`311`	`311`	`<p className="m-0 text-xs text-content-secondary">`
`312`	`312`	`Connect a{" "}`
`313`	`313`	`<Link`
`314`		`- to="/agents/settings/providers"`
	`314`	`+ to="/ai/settings"`
`315`	`315`	`className="underline transition-colors hover:text-content-primary"`
`316`	`316`	`>`
`317`	`317`	`provider`