feat: exclude aibridge/fixtures directory from scripts/check_emdash.sh#24571
Merged
pawbana merged 2 commits intoApr 22, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 21, 2026
047986b to
d3e72e7
Compare
d0a4ba9 to
fe4e775
Compare
d3e72e7 to
8be7bc5
Compare
fe4e775 to
70a38d3
Compare
4f82958 to
feca822
Compare
70a38d3 to
e7c2f9c
Compare
Contributor
There was a problem hiding this comment.
Clean, focused change that does exactly what it says. Both code paths (scan_all_files and diff-parsing) are updated to respect the exclusion, and the exclude_prefixes array is a sensible extension point.
One structural finding (P3), one documentation clarity finding (P3), one note. No blockers.
Meruem, on the dual exclusion mechanisms: "The class of bug: an exclusion that works in --all mode but silently fails in diff mode, or vice versa."
Process note: the commit subject ("add option to exclude prefixes") describes the mechanism while the PR title describes the intent. These should agree; prefer the intent framing.
🤖 This review was automatically generated with Coder Agents.
feca822 to
f6d5113
Compare
e7c2f9c to
2b573bc
Compare
dannykopping
approved these changes
Apr 21, 2026
mafredri
approved these changes
Apr 21, 2026
f6d5113 to
5c4929c
Compare
50656a0 to
58083df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds exception to emdash check to exclude
/aibridge/fixturesdirectory.