Skip to content

feat: exclude aibridge/fixtures directory from scripts/check_emdash.sh #24571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pawbana merged 2 commits into from
Apr 22, 2026
Merged

feat: exclude aibridge/fixtures directory from scripts/check_emdash.sh #24571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aeff60
feat: add option to exclude prefixes from scripts/check_emdash.sh
pawbana Apr 21, 2026
58083df
review 1: reused exclude pattern in both ls-files and diff comparison
pawbana Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/check_emdash.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,14 @@ emdash=$'\xE2\x80\x94'
endash=$'\xE2\x80\x93'
pattern="${emdash}|${endash}"

# Git exclude_pathspecs excluded from the check. Used in both ls-files and diff comparison.
exclude_pathspecs=(
":(exclude)aibridge/fixtures/**/*.txtar"
)

scan_all_files() {
local output
output=$(git ls-files -z | xargs -0 grep -IEn "$pattern" 2>/dev/null || true)
output=$(git ls-files -z -- "${exclude_pathspecs[@]}" | xargs -0 grep -IEn "$pattern" 2>/dev/null || true)
if [[ -n "$output" ]]; then
echo "$output"
found=1
Expand Down Expand Up @@ -58,7 +63,7 @@ else
fi

found=0
if ! diff_output=$(git diff "$base" -U0 -- . 2>&1); then
if ! diff_output=$(git diff "$base" -U0 -- . "${exclude_pathspecs[@]}" 2>&1); then
echo "ERROR: git diff against $base failed:"
echo "$diff_output"
exit 1
Expand Down
Loading