Skip to content

chore: add README, CI integration, and lint fixes#24586

Merged
pawbana merged 8 commits into
pb/aibridge-code-move-import-changefrom
pb/aibridge-code-move-fixes
Apr 22, 2026
Merged

chore: add README, CI integration, and lint fixes#24586
pawbana merged 8 commits into
pb/aibridge-code-move-import-changefrom
pb/aibridge-code-move-fixes

Conversation

@pawbana
Copy link
Copy Markdown
Contributor

@pawbana pawbana commented Apr 21, 2026

  • Added updated README.md.
  • Automatic linter fixes - mostly import re-ordering.
  • Import restriction - code from /aibridge directory cannot import fies from outside of it.
  • Added aibridge/** directory as go-affecting change to changes job in .github/workflows/ci.yaml
  • Updated TestAWSBedrockCredentialChain test to pass in coder CI pipeline - no credentials case was failing.
  • Removed /aibridge/fixtures directory from typo check.

Copy link
Copy Markdown
Contributor Author

pawbana commented Apr 21, 2026

Comment thread .golangci.yaml Outdated
Comment thread aibridge/AGENTS.md
@pawbana pawbana force-pushed the pb/aibridge-code-move-fixes branch from f6d5113 to 5c4929c Compare April 21, 2026 18:39
@pawbana pawbana force-pushed the pb/aibridge-code-move-import-change branch from 98b9476 to 47298db Compare April 21, 2026 18:39
@pawbana pawbana changed the title chore: Add updated README.md to aibridge chore: clean up regarding aibridge code move Apr 22, 2026
@pawbana pawbana changed the title chore: clean up regarding aibridge code move chore: add README, CI integration, and lint fixes Apr 22, 2026
Copy link
Copy Markdown
Contributor

@ssncferreira ssncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment on lines +260 to +272
"AWS_ACCESS_KEY_ID": "",
"AWS_SECRET_ACCESS_KEY": "",
"AWS_SESSION_TOKEN": "",
"AWS_PROFILE": "",
"AWS_SHARED_CREDENTIALS_FILE": "/dev/null",
"AWS_CONFIG_FILE": "/dev/null",
"AWS_WEB_IDENTITY_TOKEN_FILE": "",
"AWS_ROLE_ARN": "",
"AWS_ROLE_SESSION_NAME": "",
"AWS_CONTAINER_CREDENTIALS_RELATIVE_URI": "",
"AWS_CONTAINER_CREDENTIALS_FULL_URI": "",
"AWS_CONTAINER_AUTHORIZATION_TOKEN": "",
"AWS_EC2_METADATA_DISABLED": "true",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

#24571)

Adds exception to emdash check to exclude `/aibridge/fixtures` directory.
@pawbana pawbana merged commit d3b0559 into pb/aibridge-code-move-import-change Apr 22, 2026
22 of 25 checks passed
@pawbana pawbana deleted the pb/aibridge-code-move-fixes branch April 22, 2026 13:13
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants