Skip to content

chore: refactor cli and coderd to use ClientOptions#19763

Merged
spikecurtis merged 1 commit into
mainfrom
spike/refactor-more-client-builder
Sep 22, 2025
Merged

chore: refactor cli and coderd to use ClientOptions#19763
spikecurtis merged 1 commit into
mainfrom
spike/refactor-more-client-builder

Conversation

@spikecurtis
Copy link
Copy Markdown
Contributor

@spikecurtis spikecurtis commented Sep 10, 2025 •
edited
Loading

Refactors CLI and coderd to use the ClientBuilder pattern rather than directly instantiating the Client.

@spikecurtis spikecurtis mentioned this pull request Sep 10, 2025
Merged
This was referenced Sep 10, 2025
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Copy Markdown
Contributor Author

spikecurtis commented Sep 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis marked this pull request as ready for review September 10, 2025 11:30
@github-actions github-actions Bot added the stale This issue is like stale bread. label Sep 18, 2025
@spikecurtis spikecurtis removed the stale This issue is like stale bread. label Sep 18, 2025
@spikecurtis spikecurtis force-pushed the spike/remove-client-from-server branch from 85affd4 to 6cd9347 Compare September 18, 2025 09:48
@spikecurtis spikecurtis force-pushed the spike/refactor-more-client-builder branch from 4b8fa78 to 6997c6d Compare September 18, 2025 09:48
@spikecurtis spikecurtis changed the title chore: refactor cli and coderd to use ClientBuilder chore: refactor cli and coderd to use ClientOptions Sep 18, 2025
@spikecurtis spikecurtis force-pushed the spike/remove-client-from-server branch from 6cd9347 to a8f5864 Compare September 18, 2025 10:13
@spikecurtis spikecurtis force-pushed the spike/refactor-more-client-builder branch from 6997c6d to 41b5811 Compare September 18, 2025 10:13
mafredri
mafredri approved these changes Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@spikecurtis spikecurtis force-pushed the spike/remove-client-from-server branch from a8f5864 to 7c7f61b Compare September 22, 2025 11:48
@spikecurtis spikecurtis force-pushed the spike/refactor-more-client-builder branch from 41b5811 to 434f5d5 Compare September 22, 2025 11:48
@spikecurtis spikecurtis force-pushed the spike/remove-client-from-server branch from 7c7f61b to 52f9ef6 Compare September 22, 2025 12:01
@spikecurtis spikecurtis force-pushed the spike/refactor-more-client-builder branch from 434f5d5 to 287c45c Compare September 22, 2025 12:01
@spikecurtis Graphite App
Copy link
Copy Markdown
Contributor Author

spikecurtis commented Sep 22, 2025 •
edited
Loading

Merge activity

  • Sep 22, 1:13 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 22, 1:40 PM UTC: Graphite rebased this pull request as part of a merge.
  • Sep 22, 1:51 PM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'required', 'test-go-pg-17').

@spikecurtis spikecurtis changed the base branch from spike/remove-client-from-server to graphite-base/19763 September 22, 2025 13:27
@spikecurtis spikecurtis changed the base branch from graphite-base/19763 to main September 22, 2025 13:38
@spikecurtis spikecurtis force-pushed the spike/refactor-more-client-builder branch from 287c45c to 36552ac Compare September 22, 2025 13:39
@spikecurtis spikecurtis merged commit a30c307 into main Sep 22, 2025
47 of 49 checks passed
@spikecurtis spikecurtis deleted the spike/refactor-more-client-builder branch September 22, 2025 17:02
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@spikecurtis spikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spikecurtis @mafredri