Skip to content

chore: refactor InitClient() to use ClientOptions#19761

Merged
spikecurtis merged 1 commit into
mainfrom
spike/root-init-client-uses-builder
Sep 22, 2025
Merged

chore: refactor InitClient() to use ClientOptions#19761
spikecurtis merged 1 commit into
mainfrom
spike/root-init-client-uses-builder

Conversation

@spikecurtis
Copy link
Copy Markdown
Contributor

@spikecurtis spikecurtis commented Sep 10, 2025 •
edited
Loading

Refactors InitClient and friends to use the ClientBuilder rather than modifying a Client in place.

@spikecurtis spikecurtis mentioned this pull request Sep 10, 2025
Merged
@spikecurtis Graphite App
Copy link
Copy Markdown
Contributor Author

spikecurtis commented Sep 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Sep 10, 2025
Merged
Merged
Merged
@spikecurtis spikecurtis marked this pull request as ready for review September 10, 2025 11:27
@github-actions github-actions Bot added the stale This issue is like stale bread. label Sep 18, 2025
@spikecurtis spikecurtis removed the stale This issue is like stale bread. label Sep 18, 2025
@spikecurtis spikecurtis force-pushed the spike/root-init-client-uses-builder branch from e9af6ff to 7bb70d0 Compare September 18, 2025 09:48
@spikecurtis spikecurtis force-pushed the spike/init-client-directly branch from a617309 to 40ec132 Compare September 18, 2025 09:48
@spikecurtis spikecurtis changed the title chore: refactor InitClient() to use ClientBuilder chore: refactor InitClient() to use ClientOptions Sep 18, 2025
@spikecurtis spikecurtis force-pushed the spike/root-init-client-uses-builder branch from 7bb70d0 to 91a055c Compare September 18, 2025 10:13
@spikecurtis spikecurtis force-pushed the spike/init-client-directly branch from 40ec132 to be3c72e Compare September 18, 2025 10:13
@spikecurtis spikecurtis force-pushed the spike/root-init-client-uses-builder branch from 91a055c to bed0a70 Compare September 22, 2025 11:48
@spikecurtis spikecurtis force-pushed the spike/init-client-directly branch 3 times, most recently from a1b320d to 19ea167 Compare September 22, 2025 12:00
@spikecurtis spikecurtis force-pushed the spike/root-init-client-uses-builder branch from bed0a70 to 6c71e32 Compare September 22, 2025 12:00
@spikecurtis Graphite App
Copy link
Copy Markdown
Contributor Author

spikecurtis commented Sep 22, 2025 •
edited
Loading

Merge activity

  • Sep 22, 1:13 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 22, 1:16 PM UTC: Graphite rebased this pull request as part of a merge.
  • Sep 22, 1:26 PM UTC: @spikecurtis merged this pull request with Graphite.

@spikecurtis spikecurtis changed the base branch from spike/init-client-directly to graphite-base/19761 September 22, 2025 13:14
@spikecurtis spikecurtis changed the base branch from graphite-base/19761 to main September 22, 2025 13:14
@spikecurtis spikecurtis force-pushed the spike/root-init-client-uses-builder branch from 6c71e32 to 00c94f6 Compare September 22, 2025 13:15
@spikecurtis spikecurtis merged commit 1d0e79f into main Sep 22, 2025
27 checks passed
@spikecurtis spikecurtis deleted the spike/root-init-client-uses-builder branch September 22, 2025 13:26
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@spikecurtis spikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spikecurtis @mafredri