Skip to content

chore: cleanup unused Client in server command#19762

Merged
spikecurtis merged 1 commit into
mainfrom
spike/remove-client-from-server
Sep 22, 2025
Merged

chore: cleanup unused Client in server command#19762
spikecurtis merged 1 commit into
mainfrom
spike/remove-client-from-server

Conversation

@spikecurtis
Copy link
Copy Markdown
Contributor

@spikecurtis spikecurtis commented Sep 10, 2025 •
edited
Loading

As part of converting production code to use the new ClientBuilder, I noticed some dead code that creates a client with a URL for the only purpose of later accessing the URL. This PR removes the cruft.

@spikecurtis spikecurtis mentioned this pull request Sep 10, 2025
Merged
@spikecurtis spikecurtis mentioned this pull request Sep 10, 2025
Merged
@spikecurtis Graphite App
Copy link
Copy Markdown
Contributor Author

spikecurtis commented Sep 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Sep 10, 2025
Merged
Merged
@spikecurtis spikecurtis marked this pull request as ready for review September 10, 2025 11:29
@github-actions github-actions Bot added the stale This issue is like stale bread. label Sep 18, 2025
@spikecurtis spikecurtis force-pushed the spike/root-init-client-uses-builder branch from e9af6ff to 7bb70d0 Compare September 18, 2025 09:48
@spikecurtis spikecurtis force-pushed the spike/remove-client-from-server branch from 85affd4 to 6cd9347 Compare September 18, 2025 09:48
@spikecurtis spikecurtis force-pushed the spike/root-init-client-uses-builder branch from 7bb70d0 to 91a055c Compare September 18, 2025 10:13
@spikecurtis spikecurtis force-pushed the spike/remove-client-from-server branch from 6cd9347 to a8f5864 Compare September 18, 2025 10:13
@spikecurtis spikecurtis removed the stale This issue is like stale bread. label Sep 18, 2025
@spikecurtis spikecurtis force-pushed the spike/root-init-client-uses-builder branch from 91a055c to bed0a70 Compare September 22, 2025 11:48
@spikecurtis spikecurtis force-pushed the spike/remove-client-from-server branch from a8f5864 to 7c7f61b Compare September 22, 2025 11:48
@spikecurtis spikecurtis force-pushed the spike/root-init-client-uses-builder branch from bed0a70 to 6c71e32 Compare September 22, 2025 12:00
@spikecurtis spikecurtis force-pushed the spike/remove-client-from-server branch from 7c7f61b to 52f9ef6 Compare September 22, 2025 12:01
@spikecurtis Graphite App
Copy link
Copy Markdown
Contributor Author

spikecurtis commented Sep 22, 2025 •
edited
Loading

Merge activity

  • Sep 22, 1:13 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 22, 1:28 PM UTC: Graphite rebased this pull request as part of a merge.
  • Sep 22, 1:38 PM UTC: @spikecurtis merged this pull request with Graphite.

@spikecurtis spikecurtis changed the base branch from spike/root-init-client-uses-builder to graphite-base/19762 September 22, 2025 13:15
@spikecurtis spikecurtis changed the base branch from graphite-base/19762 to main September 22, 2025 13:26
@spikecurtis spikecurtis force-pushed the spike/remove-client-from-server branch from 52f9ef6 to bd519a7 Compare September 22, 2025 13:27
@spikecurtis spikecurtis merged commit 1734dfd into main Sep 22, 2025
27 checks passed
@spikecurtis spikecurtis deleted the spike/remove-client-from-server branch September 22, 2025 13:38
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@spikecurtis spikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spikecurtis @mafredri