Repository navigation
feat: modify config-ssh to set the host suffix - #17280
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mafredri
approved these changes
Apr 7, 2025
mafredri
left a comment
Member
There was a problem hiding this comment.
Minor nit but otherwise LGTM 👍🏻
johnstcn
reviewed
Apr 7, 2025
johnstcn
left a comment
Member
There was a problem hiding this comment.
I have one clarification regarding having both prefix and suffix enabled and expected behaviour / testing. Does it make sense to have both of these enabled?
spikecurtis
force-pushed
the
spike/host-suffix/ssh-hostname-suffix-flag
branch
from
April 7, 2025 17:18
34de3bc to
c45e4db
Compare
spikecurtis
force-pushed
the
spike/host-suffix/config-ssh-uses-host-suffix
branch
from
April 7, 2025 17:18
2cac087 to
237f8e4
Compare
spikecurtis
changed the base branch from
spike/host-suffix/ssh-hostname-suffix-flag
to
graphite-base/17280
April 7, 2025 17:33
spikecurtis
force-pushed
the
spike/host-suffix/config-ssh-uses-host-suffix
branch
from
April 7, 2025 17:33
237f8e4 to
0ae03f3
Compare
spikecurtis
force-pushed
the
graphite-base/17280
branch
from
April 7, 2025 17:33
c45e4db to
d312e82
Compare
spikecurtis
force-pushed
the
spike/host-suffix/config-ssh-uses-host-suffix
branch
from
April 7, 2025 17:34
0ae03f3 to
283830c
Compare
johnstcn
approved these changes
Apr 7, 2025
spikecurtis
force-pushed
the
spike/host-suffix/config-ssh-uses-host-suffix
branch
from
April 8, 2025 07:38
283830c to
b78738c
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Wires up
config-sshcommand to use a hostname suffix if configured.part of: #16828
e.g.
coder config-ssh --hostname-suffix spiketestgives: