Skip to content

Refactor SSH prefix into a workspace suffix #16828

Closed
Chore
2 of 3 issues completed
#17445
Closed
Refactor SSH prefix into a workspace suffix#16828
Chore
2 of 3 issues completed
#17445
Assignees
spikecurtis

Description

@ThomasK33
ThomasK33
opened on Mar 6, 2025

To implement one-click buttons for native applications in Coder Desktop, we need to refactor how (SSH) hostnames are handled⁠.

Currently, Coder uses a hostname prefix for SSH configuration, but this approach is incompatible with Coder Desktop which requires a suffix-based approach. This refactoring is necessary to enable seamless deep linking and native application launches⁠⁠.

Tasks include:

  • Deprecate the existing hostname prefix option⁠⁠
  • Implement a new hostname suffix option to be used by the config-ssh command and Coder Desktop (e.g., HostnameSuffix, defaulting to coder)⁠
  • Update the config-ssh subcommand to reflect these changes⁠⁠
  • Dynamically configure VPN DNS settings & workspace hostnames based on the hostname suffix

Activity

  1. ThomasK33
    added a parent issue on Mar 6, 2025
  2. ThomasK33
    added a sub-issue on Mar 6, 2025
  3. matifali
    added the
    Chore
    issue type on Mar 6, 2025
  4. bpmct
    added a commit that references this issue on Mar 6, 2025

    feat: refactor SSH prefix into a workspace suffix

    fafec8b

  5. aaronlehmann commented on Mar 8, 2025

    @aaronlehmann
    aaronlehmann
    on Mar 8, 2025
    Contributor

    Are you planning to change the IDE plugins to use a suffix rather than a prefix?

  6. ThomasK33 commented on Mar 10, 2025

    @ThomasK33
    ThomasK33
    on Mar 10, 2025
    MemberAuthor

    Are you planning to change the IDE plugins to use a suffix rather than a prefix?

    Hey @aaronlehmann 👋 , yes, we will update the plugins to use the suffix and make them aware of the existing Coder Desktop tunnel.

    Just a heads up, those changes will come in a later phase, so keep an eye on the parent issue (phase 1) for more info.

  7. bpmct
    added a commit that references this issue on Mar 10, 2025

    feat: Add base_image parameter to Docker template

    0b0217f
  8. matifali
    added a sub-issue on Mar 10, 2025
  9. ThomasK33
    added a sub-issue on Mar 11, 2025

  10. deansheather commented on Mar 11, 2025

    @deansheather
    deansheather
    on Mar 11, 2025
    Collaborator

    Since this needs to be used by the UI, the extensions and the desktop apps, it will most likely need to be a server-side option for consistency

  11. spikecurtis
    self-assigned this
    on Apr 4, 2025
  12. spikecurtis
    added 8 commits that reference this issue on Apr 7, 2025

    feat: support --hostname-suffix flag on coder ssh (#17279)

    d312e82

    feat: modify config-ssh to set the host suffix (#17280)

    9eeb506

    feat: return hostname suffix on AgentConnectionInfo (#17334)

    12dc086

    feat: vpn uses WorkspaceHostnameSuffix for DNS names (#17335)

    2c573dc

    feat: add configurable DNS match domain for tailnet connections (#17336)

    9e2af3e

    feat: add IsCoderConnectRunning to workspacesdk (#17361)

    e5ce382

    feat: modify config-ssh to check for Coder Connect (#17419)

    b0854aa

    chore: change config-ssh Call to Action to use suffix (#17445)

    9fe3fd4
  13. spikecurtis
    closed this as completedin #17445on Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Chore

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions