Repository navigation
feat: support --hostname-suffix flag on coder ssh - #17279
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mafredri
approved these changes
Apr 7, 2025
johnstcn
approved these changes
Apr 7, 2025
johnstcn
left a comment
Member
There was a problem hiding this comment.
One nit on the cmd docs, but otherwise LGTM!
spikecurtis
force-pushed
the
spike/host-suffix/ssh-hostname-suffix-flag
branch
from
April 7, 2025 17:18
34de3bc to
c45e4db
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
hostname-suffixflag tocoder sshcommand for use in SSH Config ProxyCommands.Also enforces that Coder server doesn't start the suffix with a dot.
part of: #16828