Skip to content

Revert "Revert "NetSim: Teacher view dropdown bug""#9819

Merged
islemaster merged 1 commit into
stagingfrom
revert-9818-revert-9809-netsim-teacher-view-dropdown-bug
Aug 4, 2016
Merged

Revert "Revert "NetSim: Teacher view dropdown bug""#9819
islemaster merged 1 commit into
stagingfrom
revert-9818-revert-9809-netsim-teacher-view-dropdown-bug

Conversation

@islemaster

@islemaster islemaster commented Aug 3, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #9818
Unreverts #9809

Original PR was reverted unit tests it introduced failed on our staging machine.

Failure reported on staging (terminal style codes removed):

FAILED TESTS:
  SentByDropdown
    – only shows each name once
      PhantomJS 2.1.1 (Linux 0.0.0)
    expected { Object (component, root, ...) } to have a length of 1 but got 0
    AssertionError@[CDO]/apps/test/unit-tests.js:470:25 <- webpack:///~/chai/~/assertion-error/index.js:74:0
    assert@[CDO]/apps/test/unit-tests.js:4571:32 <- webpack:///~/chai/lib/chai/assertion.js:107:0
    assertLength@[CDO]/apps/test/unit-tests.js:5646:17 <- webpack:///~/chai/lib/chai/core/assertions.js:1045:0
    assert@[CDO]/apps/test/unit-tests.js:4370:55 <- webpack:///~/chai/lib/chai/utils/addChainableMethod.js:84:0
    [CDO]/apps/test/unit-tests.js:261719:89 <- webpack:///test/unit/netsim/NetSimLogBrowserFilters.js:81:67

Warning: Task "karma:unit" failed. Use --force to continue.

@islemaster

islemaster commented Aug 3, 2016

Copy link
Copy Markdown
Contributor Author

😡 Passed on CircleCI again. I wonder what went wrong on staging?

@islemaster islemaster mentioned this pull request Aug 3, 2016
Merged
@islemaster

islemaster commented Aug 4, 2016

Copy link
Copy Markdown
Contributor Author

Trying again, unmodified. I have no real reason yet to believe this is broken.

@islemaster islemaster merged commit ea1c94b into staging Aug 4, 2016
@islemaster islemaster deleted the revert-9818-revert-9809-netsim-teacher-view-dropdown-bug branch August 4, 2016 17:06
@islemaster islemaster mentioned this pull request Aug 4, 2016
Merged
deploy-code-org added a commit that referenced this pull request Aug 4, 2016
@deploy-code-org
Automatically built.
06e50ec 
ea1c94b Merge pull request #9819 from code-dot-org/revert-9818-revert-9809-netsim-teacher-view-dropdown-bug (Brad Buchanan)
c23055b Merge pull request #9821 from code-dot-org/unlimited_peer_reviews (Mehal Shah)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@islemaster