NetSim: Fix spurious auto-DNS warning#9820
Merged
Merged
Conversation
Contributor
|
For anything JS, I'm very much the wrong person to review. |
@ashercodeorg reported this warning from his console: > Packet not readable by auto-DNS: Error: Unable to select a bit-width for field undefined Warning was caused by a bad query in the new logging code about whether a given packet was from the Auto-DNS node, when in broadcast mode there _is_ no Auto-DNS node. It seems sensible for that query to always return false if auto-DNS is not enabled, so I've updated it (and the corresponding "to auto-DNS" query) to do so.
d220b78 to
a6bada1
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ashercodeorg reported this warning from his console (original report):
Warning was caused by a bad query in the new logging code about whether a given packet was from the Auto-DNS node, when in broadcast mode there is no Auto-DNS node. It seems sensible for that query to always return false if auto-DNS is not enabled, so I've updated it (and the corresponding "to auto-DNS" query) to do so.
Waiting on #9819 and #9816 - please only review last commit d220b78