NetSim: Teacher view dropdown bug#9809
Merged
Merged
Conversation
| {this.props.i18n.logBrowserHeader_sentByAnyone()} | ||
| </option> | ||
| {_.uniq(this.props.logRows.map(row => row.sentBy)) | ||
| {_.uniq(this.props.logRows.map(row => row['sent-by'])) |
Contributor
Author
There was a problem hiding this comment.
This is the actual bugfix.
Member
|
The fix itself looks good. I'll take a closer look at the tests and chai/enzyme today. |
Contributor
Author
|
I'm going to go ahead and merge then, since the test changes are unit test only and are passing on CircleCI. |
This was referenced Aug 3, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sfilman reported a bug in the new Teacher View sent-by dropdown during our bug bash today (original report). The dropdown had an
undefinedentry instead of a list of message senders.The fix is trivial (I was referring to the wrong property name). I've gone ahead and added some simple tests, too. The tests make use of these libraries, which it may be useful to know about: