DTP#9555
Merged
Merged
Conversation
Conflicts: dashboard/app/helpers/levels_helper.rb
This required a dashboard change so that we pass the is13Plus flag in the app config to all level views, not just to project views. I'm a little worried about the implications of this, but by passing it to project pages we weren't protecting it particularly well before, and at the very least it does appear to be available on all share pages. I ran all the apps tests and projects.feature, and everything passed, so I expect the existing behavior is preserved.
Add lesson plan links to algebraa and csd3 scripts
Test > Levelbuilder
Defines hashed_email (fixing bug) and uses contact_email (fixing bug).
add redirects for deprecated CSP pages
…new applab projects created via 'Create New'
Make the sourceSize animation property ephemeral, not part of the SerializedAnimationProps type, because we can always infer it once the asset is loaded. Instead we add a step to our loadfromsource process to determine the dimensions of the asset right before we are done loading.
Levelbuilder > Staging
levelbuilder -> staging (brendan)
DTT (Staging > Test)
…arning Game Lab: Animation picker warning
Change property of image object from picture to image in design view
Remove documentation of removed sourceSize property
Kills the unsubscribed? method.
Update export format for utils.js
Revert: Revert: "Remove abilities from admins."
Change key blocks to use strings
Wipes plaintext email for students from Poste2.
DTT (Staging > Test)
Today Brooke and Mehal reported the following uncaught exception in the NetSimRouterLogModal: > Uncaught ReferenceError: localAddress is not defined There's a reference to `localAddress` when it should be `locals.localAddress`. Here we cover that behavior with a _very_ dumb test, and fix it.
Fix uncaught exception in RouterLogModal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.