Wipes plaintext email for students from Poste2.#9545
Merged
Conversation
| contact[:email] = email | ||
| sanitized_email = Poste.dashboard_student?(hashed_email) ? '' : email | ||
| id = POSTE_DB[:contacts].insert({}.tap do |contact| | ||
| contact[:email] = sanitized_email |
Contributor
There was a problem hiding this comment.
Not important: I know you didn't write this code, and it's mostly extraneous to this PR, but any idea why it's using {}.tap rather than just creating a hash inline?
That seems a strange and unnecessary pattern. The only reason I can see is the optional name field, but since this is inserting in the DB wouldn't a hash with name: nil resolve to the same thing as as a hash with no name key?
It can be converted to:
id = POSTE_DB[:contacts].insert({
email: sanitized_email,
hashed_email: hashed_email,
name: name,
#...
})
Contributor
Author
There was a problem hiding this comment.
Nope. And I'm happy to "fix" in a followup PR.
Contributor
|
Nice new test coverage! It looks like some setup is missing (or I am missing something). See above comments. |
Contributor
|
LGTM with the setup in the 2nd commit, presuming tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds significant test coverage to existing methods.