Skip to content

DTT#9

Merged
davidsbailey merged 16 commits into
testfrom
staging
Sep 22, 2014
Merged

DTT#9
davidsbailey merged 16 commits into
testfrom
staging

Conversation

@davidsbailey

Copy link
Copy Markdown
Member

No description provided.

rlhawk and others added 16 commits September 22, 2014 13:53
Change to use local_file filename path so we save using original extension (rather than .fetch) on S3
employee engagement: unauthorized -> not_authorized
Sharing fixes, Logo fix for add to home screen
commit c0138ff
Merge: 9207f45 065dabf
Author: cpirich <chris@code.org>
Date:   Mon Sep 22 14:30:03 2014 -0700

    Merge pull request #6 from code-dot-org/sharing_fixes

    Sharing fixes, Logo fix for add to home screen

commit 9207f45
Merge: c6ecd39 1ce54d5
Author: davidsbailey <davidsbailey@users.noreply.github.com>
Date:   Mon Sep 22 14:15:33 2014 -0700

    Merge pull request #8 from code-dot-org/hoc-ee-fixauth

    employee engagement: unauthorized -> not_authorized

commit 1ce54d5
Author: David Bailey <dsb123@gmail.com>
Date:   Mon Sep 22 14:13:51 2014 -0700

    employee engagement: unauthorized -> not_authorized

commit c6ecd39
Merge: a14c9f5 cc30b67
Author: Brian Jordan <bcjordan@gmail.com>
Date:   Mon Sep 22 14:12:09 2014 -0700

    Merge pull request #7 from code-dot-org/change_s3_save_filename

    Change to use local_file filename path so we save using original extension (rather than .fetch) on S3

commit cc30b67
Author: Brian Jordan <bcjordan@gmail.com>
Date:   Mon Sep 22 14:11:31 2014 -0700

    Change to use local_file filename path so we save using original extension (rather than .fetch) on S3
davidsbailey added a commit that referenced this pull request Sep 22, 2014
@davidsbailey davidsbailey merged commit d9f9715 into test Sep 22, 2014
Erin007 added a commit that referenced this pull request Nov 10, 2017
# This is the 1st commit message:
delete icloud hitchhikers

# The commit message #2 will be skipped:

#	delete hitchhikers

# The commit message #3 will be skipped:

#	remove hitchhikers

# The commit message #4 will be skipped:

#	remove hitchhikers

# The commit message #5 will be skipped:

#	delete hitchhikers

# The commit message #6 will be skipped:

#	delete .icloud files'

# The commit message #7 will be skipped:

#	delete hitchhikers

# The commit message #8 will be skipped:

#	remove hitchhiker icloud files

# The commit message #9 will be skipped:

#	delete icloud files'

# The commit message #10 will be skipped:

#	delete hitchhikers
sureshc added a commit that referenced this pull request Aug 31, 2020
stephenliang pushed a commit that referenced this pull request May 7, 2026
stephenliang added a commit that referenced this pull request Jun 9, 2026
… a11y label, :active border

- GlobalNavItem is a link|group discriminated union (href required for link
  entries), so a direct-link entry can no longer render a dead <a> (#8).
- NavLogo aria-label falls back to 'Home' when brandName is omitted (#9).
- buildSupportLinks is typed UserType, not string; UserType is re-exported
  from the header package (#10).
- CreateMenu/HelpButton/HamburgerMenu read HEADER_BREAKPOINTS instead of
  hardcoded 1200/1060/1061; desktopFull is now used (#11).
- The dropdown panel surface lives once as MENU_SURFACE, shared by the menus,
  the create picker, and the hamburger popover (#12).
- New project + Account re-pin their white border in the :active block; the
  theme's Button :active rule otherwise recolors it to transparent (#16),
  guarded by a press-and-hold assertion in the story.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants