Revert "Revert "Update student view of Curriculum Catalog cards""#56517
Merged
TurnerRiley merged 4 commits intoFeb 14, 2024
Merged
Conversation
hannahbergam
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the detailed description! Do you know why the aria-label issue only happened on mobile?
Contributor
Author
Yep it was an |
This was referenced Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #56507 (which reverted #56322 due to a failing mobile UI test). Since the mobile UI test wasn't run on drone, I didn't know it was failing until it hit the test server. For this re-revert I pushed the empty commit to
test iosand ensure that this PR runs mobile UI tests within its drone runs.The issue was that I updated this aria-label but then forgot to update the UI test to accomodate, so it was unable to find the element by aria-label.