Revert "Revert "Revert "Revert "Update student view of Curriculum Catalog cards""""#56583
Merged
Conversation
…alog car…" This reverts commit 9cce09c.
bethanyaconnor
approved these changes
Feb 16, 2024
bethanyaconnor
left a comment
Contributor
There was a problem hiding this comment.
🤞 thanks for the persistence here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #56582
Sorry for the re-re-re-revert. I thought the previous change would work because of the passing test following the
[test ios]commit, I didn't realize you needed to include[test ios]per commit you wanted tested. This PR does that and I found that the issue was whether "now" was capitalized or not.As shown below, the show failing baseline [test ios] commit fails, and once the change is implemented it now passes. The reason for the baseline [test ios] commit followed by making the fix then undoing the fix was because I wanted to show a failing commit without the change and a successful one with it, but I pushed both at the same time so drone only ran on the successful one. So, I just undid the fix to get a failing drone build then reimplemented the fix to get a successful one to feel confident that it'll work this time.