Update student view of Curriculum Catalog cards#56322
Merged
Merged
Conversation
Contributor
Author
kelbyhawn
approved these changes
Feb 8, 2024
kelbyhawn
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me! I have one non-blocking question, but you may want to wait to have someone else with more testing knowledge approve before merging.
| text={assignButtonText} | ||
| className={style.buttonFlex} | ||
| href={pathToCourse} | ||
| aria-label={i18n.tryNow()} |
Contributor
There was a problem hiding this comment.
Non-blocking: can this aria label show the course name with course_name: courseDisplayName, too?
bethanyaconnor
approved these changes
Feb 9, 2024
bethanyaconnor
left a comment
Contributor
There was a problem hiding this comment.
Looks good after addressing Kelby's comment!
ebeastlake
added a commit
that referenced
this pull request
Feb 10, 2024
This reverts commit 8c06377.
ebeastlake
added a commit
that referenced
this pull request
Feb 10, 2024
TurnerRiley
added a commit
that referenced
this pull request
Feb 12, 2024
TurnerRiley
added a commit
that referenced
this pull request
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the signed-in student view of the Curriculum Catalog cards. The idea is to update the buttons to give students a clearer route to trying out the given card's course.
The changes:
Demos
Catalog card
Previous student view:
New student view:
Teacher and Signed-out view (unchanged):
Expanded card
Previous student view:
New student view:
Teacher and Signed-out view (unchanged):
Mobile view to show view when an expanded card can't fit
Previous student view:
New student view:
Teacher and Signed-out view (unchanged):
Links
Jira ticket: here
Testing story
Local testing.